Skip to content

fix(workflow): handle individual PR download failures in prompt-clustering-analysis #18139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 24, 2026
Merged

fix(workflow): handle individual PR download failures in prompt-clustering-analysis #18139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f58c03
Initial plan
Copilot Feb 24, 2026
a9d8598
initial plan for fixing prompt-clustering-analysis workflow failure
Copilot Feb 24, 2026
99b7cb6
fix(workflow): add error handling to PR download loop in prompt-clust…
Copilot Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/prompt-clustering-analysis.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 8 additions & 4 deletions .github/workflows/prompt-clustering-analysis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,16 @@ steps:
echo "Downloading full data for PR #$pr_number..."

# Download full PR data with essential fields only
gh pr view "$pr_number" \
# Use error handling to skip individual PR failures (e.g. deleted PRs, rate limits)
if gh pr view "$pr_number" \
--repo "${{ github.repository }}" \
--json number,title,body,state,createdAt,closedAt,mergedAt,url,comments,reviews,commits,changedFiles,additions,deletions,reviewDecision \
> "/tmp/gh-aw/prompt-cache/pr-full-data/pr-${pr_number}.json"

echo "Downloaded PR #$pr_number"
> "/tmp/gh-aw/prompt-cache/pr-full-data/pr-${pr_number}.json" 2>/tmp/gh-aw/prompt-cache/pr-full-data/pr-${pr_number}.err; then
echo "Downloaded PR #$pr_number"
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stderr redirection creates an .err file for every successful PR download (even if empty), and it isn’t cleaned up in the success path. Since /tmp/gh-aw/prompt-cache is cached later, this can unnecessarily bloat the cache and slow workflow runs. Consider removing the .err file on success (or only writing stderr to a file when the command fails).

Suggested change
echo "Downloaded PR #$pr_number"
echo "Downloaded PR #$pr_number"
rm -f "/tmp/gh-aw/prompt-cache/pr-full-data/pr-${pr_number}.err"

Copilot uses AI. Check for mistakes.
else
echo "Warning: Failed to download PR #$pr_number (skipping)"
rm -f "/tmp/gh-aw/prompt-cache/pr-full-data/pr-${pr_number}.json" "/tmp/gh-aw/prompt-cache/pr-full-data/pr-${pr_number}.err"
fi
done

# Create an index file listing all downloaded PRs
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/smoke-copilot.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.