Conversation
…rdize Recompile workflows Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Standardizes GitHub Actions workflow step names across compiled workflows to improve log readability and align terminology (notably “Upload charts” and “Recompile workflows”), with corresponding regenerated .lock.yml outputs.
Changes:
- Renamed the shared dataviz artifact step to “Upload charts” and propagated to importing workflows via recompilation.
- Standardized recompilation terminology to “Recompile workflows” for
make recompilesteps. - Simplified several compound/ambiguous step names in source
.mdworkflows and regenerated affected.lock.ymlfiles.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/shared/python-dataviz.md | Standardizes the shared artifact upload step name to “Upload charts”. |
| .github/workflows/shared/ci-data-analysis.md | Renames the recompilation step to “Recompile workflows”. |
| .github/workflows/daily-news.md | Simplifies a compound step name in the source workflow. |
| .github/workflows/release.md | Simplifies a compound step name in the source workflow. |
| .github/workflows/ci-doctor.md | Simplifies a compound step name in the source workflow. |
| .github/workflows/weekly-issue-summary.lock.yml | Regenerated compiled workflow reflecting “Upload charts”. |
| .github/workflows/stale-repo-identifier.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/python-data-charts.lock.yml | Regenerated compiled workflow reflecting “Upload charts”. |
| .github/workflows/org-health-report.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/daily-repo-chronicle.lock.yml | Regenerated compiled workflow reflecting “Upload charts”. |
| .github/workflows/daily-news.lock.yml | Regenerated compiled workflow reflecting updated step names (and updated metadata). |
| .github/workflows/daily-issues-report.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/daily-copilot-token-report.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/daily-code-metrics.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/copilot-session-insights.lock.yml | Regenerated compiled workflow reflecting “Upload charts”. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Regenerated compiled workflow reflecting “Upload charts” (and updated metadata). |
| .github/workflows/release.lock.yml | Regenerated compiled workflow reflecting updated step name (and updated metadata). |
| .github/workflows/ci-doctor.lock.yml | Regenerated compiled workflow reflecting updated step name (and updated metadata). |
| .github/workflows/ci-coach.lock.yml | Regenerated compiled workflow reflecting “Recompile workflows” (and updated metadata). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Setup working directories | ||
| id: check-cache |
There was a problem hiding this comment.
The step is still responsible for both creating directories and performing the cache validation / outputting cache_valid. Renaming it to only “Setup working directories” makes the logs harder to interpret when debugging cache behavior. Consider either splitting the cache check into a separate step or renaming this step to reflect that it performs a cache check as well (while still avoiding an overly compound name).
| - name: Setup release environment | ||
| env: | ||
| RELEASE_ID: ${{ needs.release.outputs.release_id }} | ||
| RELEASE_TAG: ${{ needs.config.outputs.release_tag }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | |
There was a problem hiding this comment.
This step does substantially more than environment setup (it fetches release metadata, PRs, issues, and writes multiple files under /tmp/gh-aw/release-data). The new name “Setup release environment” may be misleading when scanning logs. Consider splitting into dedicated steps (e.g., environment setup vs data fetching) or renaming to reflect the data-fetching responsibility.
| - name: Download CI failure logs and artifacts | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| RUN_ID: ${{ github.event.workflow_run.id }} | ||
| REPO: ${{ github.repository }} | ||
| run: | | ||
| set -e | ||
| LOG_DIR="/tmp/ci-doctor/logs" | ||
| ARTIFACT_DIR="/tmp/ci-doctor/artifacts" | ||
| FILTERED_DIR="/tmp/ci-doctor/filtered" | ||
| mkdir -p "$LOG_DIR" "$ARTIFACT_DIR" "$FILTERED_DIR" | ||
|
|
||
| echo "=== CI Doctor: Pre-downloading logs and artifacts for run $RUN_ID ===" |
There was a problem hiding this comment.
The step still performs both downloading and heuristic filtering/summary generation (see the grep/"hints" and summary sections). With the new name focusing only on downloads, the step name no longer reflects the heuristic pre-analysis work happening here. Consider splitting heuristics/summary into a separate step or adjusting the name to cover the analysis output as well.
Step names across 18+ compiled workflows were inconsistent:
"Upload generated charts"vs"Upload charts", compound names violating single-responsibility ("Setup directories and check cache"), and divergent verbs for the same recompilation operation ("Rebuild lock files"vs"Recompile workflows").All fixes applied to source
.mdfiles; lock files regenerated viamake recompile.Changes
shared/python-dataviz.md—"Upload generated charts"→"Upload charts": single shared-component fix propagates to all 12 importing workflows, eliminating the split and aligning with theUpload <artifact>patternshared/ci-data-analysis.md—"Rebuild lock files"→"Recompile workflows": aligns with glossary definition of "Compilation" and the verb used indaily-copilot-token-reportdaily-news.md—"Setup directories and check cache"→"Setup working directories"release.md—"Setup environment and fetch release data"→"Setup release environment"ci-doctor.md—"Pre-download CI failure logs and artifacts, apply heuristics"→"Download CI failure logs and artifacts"Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw BQzMeqY/wkPmaBKx-1(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -w -buildmode=exe git t-39�� k/gh-aw/gh-aw/.github/workflows/auto-triage-issues.md -extld=gcc /usr/bin/git -json GO111MODULE 64/bin/go git(http block)https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1/usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha SameOutput3386773209/001/stability-test.md /tmp/go-build2155661420/b125/vet.cfg 5661420/b390/_pkg_.a d7ab9ec12dbe903egit GO111MODULE 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� -unreachable=false(http block)/usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha ithub-script/git/ref/tags/v8 go 0/x64/bin/node aw/actions-lock.git GO111MODULE /opt/hostedtoolc--show-toplevel 0/x64/bin/node rev-�� --show-toplevel go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link on' --ignore-patgit GO111MODULE es/.bin/node /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link(http block)/usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha origin main 0/x64/bin/node --show-toplevel /bin/sh /usr/bin/git git arne�� --show-toplevel git 0/x64/bin/node /tmp/gh-aw-test-git config 0/x64/bin/node git(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/11bd71901bbe5b1630ceea73d27597364c9af683/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/11bd71901bbe5b1630ceea73d27597364c9af683 --jq .object.sha(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v3/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha sole.test GO111MODULE ortcfg.link GOINSECURE GOMOD GOMODCACHE Ey0dPZIRGnmVdmKxI4/X0HLTQaA8PlvK/tmp/go-build2155661420/b113/vet.cfg(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha --write ../../../**/*.json /usr/bin/git --ignore-path ../../../.pretti-1 0/x64/bin/node git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE ache/go/1.25.0/x--show-toplevel git(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha --show-toplevel gh /usr/bin/git /repos/actions/ggit --jq /usr/bin/infocmp--show-toplevel git s ]*:[[:space:]]*"(create_pull_request|push_to_pull_request_branch)" infocmp /opt/hostedtoolcache/uv/0.10.5/x86_64/node xterm-color go epo.git node(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha t.go t_test.go /opt/hostedtoolcache/go/1.25.0/x-buildmode=exe GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.0/x-extld=gcc -uns�� runs/20260224-211901-29663/test-1849949833/.github/workflows /tmp/go-build2155661420/b036/vet.cfg /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet l GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha brave.md 5661420/b064/vet.cfg /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� -unreachable=false /tmp/go-build2155661420/b055/vet.cfg /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet GOSUMDB GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha t0 go(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v5/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha 1089422245/.github/workflows .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha k/gh-aw/gh-aw/pkg/cli -buildtags ache/go/1.25.0/x64/pkg/tool/linux_amd64/link -errorsas -ifaceassert -nilfunc ache/go/1.25.0/x64/pkg/tool/linux_amd64/link rev-�� 5661420/b426/timeutil.test -tests 5661420/b426/importcfg.link k/gh-aw/gh-aw/pkgit k/gh-aw/gh-aw/pkrev-parse 64/bin/go iiEtxJ64HjgrP/g5FpiJ9ENbZatjTay5oJ/BhqTCoRMGewfss9ZXZGY/X4XoDkfiiEtxJ64HjgrP(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha GOMODCACHE x_amd64/vet /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --git-dir x_amd64/vet /opt/hostedtoolcache/node/24.13.0/x64/bin/node -json GO111MODULE x_amd64/vet /opt/hostedtoolcache/node/24.13.0/x64/bin/node(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v6/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha(http block)https://api.github.com/repos/actions/github-script/git/ref/tags/v7/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v7 --jq .object.sha(http block)https://api.github.com/repos/actions/github-script/git/ref/tags/v8/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha npx prettier --cGOSUMDB GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go sh -c "prettier" --check 'scripts/**/*GOINSECURE node 64/bin/go tierignore ../../../pkg/wor-atomic 64/bin/go go(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha che/go-build/64/-errorsas **/*.cjs 64/bin/go **/*.json --ignore-path ../../../.pretti-unreachable=false u69dtnPwupbS -o /tmp/go-build3273722775/b414/_pkGOINSECURE -trimpath 64/bin/go -p github.com/githu-atomic -lang=go1.25 go(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha prettier --check 64/bin/go --ignore-path .prettierignore 64/bin/go go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/4dc6199c7b1a012772edbd06daecab0f50c9053c/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/4dc6199c7b1a012772edbd06daecab0f50c9053c --jq .object.sha(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� -unreachable=false /tmp/go-build2155661420/b051/vet.cfg 5661420/b307/vet.cfg GOSUMDB GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha --show-toplevel go /usr/bin/git heck '**/*.cjs' git GO111MODULE 0/x64/bin/node git rev-�� runs/20260224-212558-44553/test---workflow go /usr/bin/git l GO111MODULE /opt/hostedtoolc--show-toplevel git(http block)/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha --show-toplevel git /usr/bin/sed sistency_GoAndJagit Test User /usr/bin/git sed s/-$�� node /usr/bin/git 0/x64/bin/node -v go ache/node/24.13.--show-toplevel git(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/v5/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v5 --jq .object.sha(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/v6/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v6 --jq .object.sha(http block)https://api.github.com/repos/actions/setup-node/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha bot-detection.md GO111MODULE /opt/hostedtoolcache/go/1.25.0/x-test.short=true GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� runs/20260224-211901-29663/test-1849949833/.github/workflows /tmp/go-build2155661420/b050/vet.cfg 0/x64/bin/node l GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha 86 go /usr/bin/git /ref/tags/v8 GO111MODULE 0/x64/bin/node git conf�� 2558-44553/test-1979431220 test@example.com /usr/bin/git ithub/workflows/git GO111MODULE /opt/hostedtoolc--show-toplevel git(http block)/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha --show-toplevel git /usr/bin/sed --git-dir ache/go/1.25.0/xrev-parse /usr/bin/gh sed s/-\�� _modules/.bin/no--show-toplevel gh 0/x64/bin/node list(http block)https://api.github.com/repos/actions/setup-node/git/ref/tags/v6/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq .object.sha(http block)/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build187316177/b001/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/main.go(http block)https://api.github.com/repos/anchore/sbom-action/git/ref/tags/v0/usr/bin/gh gh api /repos/anchore/sbom-action/git/ref/tags/v0 --jq .object.sha(http block)https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b/usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha(http block)https://api.github.com/repos/docker/build-push-action/git/ref/tags/v6/usr/bin/gh gh api /repos/docker/build-push-action/git/ref/tags/v6 --jq .object.sha(http block)https://api.github.com/repos/docker/login-action/git/ref/tags/v3/usr/bin/gh gh api /repos/docker/login-action/git/ref/tags/v3 --jq .object.sha(http block)https://api.github.com/repos/docker/metadata-action/git/ref/tags/v5/usr/bin/gh gh api /repos/docker/metadata-action/git/ref/tags/v5 --jq .object.sha(http block)https://api.github.com/repos/docker/setup-buildx-action/git/ref/tags/v3/usr/bin/gh gh api /repos/docker/setup-buildx-action/git/ref/tags/v3 --jq .object.sha(http block)https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts/usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuremote.origin.url(http block)/usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 0498221/b383/vet.cfg GOINSECURE GOMOD GOMODCACHE node /hom�� ../pkg/workflow/js/**/*.json' ---errorsas **/*.cjs ache/node/24.13.0/x64/bin/node **/*.json --ignore-path ../../../.prettiuser.email /opt/hostedtoolctest@example.com(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet estl�� -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE sh GOINSECURE GOMOD GOMODCACHE node /hom�� ../pkg/workflow/@{u} l x_amd64/vet **/*.json --ignore-path ../../../.pretti--show-toplevel x_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet estl�� -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linutest@example.com(http block)/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 0498221/b373/vet.cfg GOINSECURE GOMOD GOMODCACHE node /hom�� ../pkg/workflow/js/**/*.json' ---errorsas l x_amd64/vet **/*.json --ignore-path ../../../.pretti--show-toplevel x_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts/usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE 0498221/b389/vet.cfg GOINSECURE GOMOD run-script/lib/n/tmp/gh-aw-test-runs/20260224-212252-43413/test-853675110 node /hom�� ../pkg/workflow/.github/workflows/test.md l /opt/hostedtoolcache/go/1.25.0/x-test.short=true **/*.json --ignore-path ../../../.pretti--git-dir /opt/hostedtoolcache/go/1.25.0/xconfig(http block)https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts/usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE x_amd64/cgo GOINSECURE GOMOD GOMODCACHE x_amd64/cgo env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE 0498221/b392/vet.cfg GOINSECURE GOMOD GOMODCACHE node /hom�� ../pkg/workflow/js/**/*.json' ---errorsas **/*.cjs /tmp/go-build2300498221/b381/cli-nilfunc **/*.json --ignore-path ../../../.pretti--show-toplevel /tmp/go-build2300498221/b381/cli-tests(http block)https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts/usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE 64/pkg/tool/linu-buildmode=exe GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu-extld=gcc env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE /home/REDACTED/work/gh-aw/gh-aw/actions/setup/node_modules/.bin/node GOINSECURE GOMOD GOMODCACHE node /hom�� ../pkg/workflow/js/**/*.json' --ignore-path ../../../.prettierignore(http block)https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts/usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run download 5 --dir test-logs/run-5 l 0498221/b372/vet.cfg GOINSECURE GOMOD GOMODCACHE node /hom�� ../pkg/workflow/@{u} **/*.cjs /opt/hostedtoolcache/go/1.25.0/x-nilfunc **/*.json --ignore-path ../../../.pretti--show-toplevel /opt/hostedtoolcache/go/1.25.0/x-tests(http block)https://api.github.com/repos/github/gh-aw/actions/workflows/usr/bin/gh gh workflow list --json name,state,path npx prettier --cGOSUMDB GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go node /hom�� --check scripts/**/*.js 64/bin/go .prettierignore sh 64/bin/go go(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 git 64/bin/go go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE x_amd64/link env -json GO111MODULE 64/pkg/tool/linu-importcfg GOINSECURE GOMOD GOMODCACHE I4/X0HLTQaA8PlvK/tmp/go-build2155661420/b113/vet.cfg(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb --jq .object.sha(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env ty-test.md .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha *.json' '!../../../pkg/workflow/js/**/*.json' --ignore-path ../../../.prettierignore go /usr/bin/git q "All matched fgh GO111MODULE 64/bin/go git conf�� ub/workflows t1970381017/.github/workflows/test.lock.yml t1970381017/.gitattributes re GO111MODULE 64/bin/go git(http block)/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha --show-toplevel sh /usr/bin/git 3774127002 x_amd64/vet /home/REDACTED/work/node_modules/.--show-toplevel git rev-�� --show-toplevel node /opt/hostedtoolcache/node/24.13.0/x64/bin/node prettier --write hutil.test /opt/hostedtoolcache/node/24.13.0/x64/bin/node(http block)https://api.github.com/repos/githubnext/agentics/git/ref/tags//usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha(http block)https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999/usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuTest User env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha *.json' '!../../--repo go ache/uv/0.10.5/x86_64/node ath ../../../.prgit GO111MODULE 64/bin/go git ache�� 2252-43413/test-3981202048/.github/workflows go e_modules/.bin/sh -json GO111MODULE ode-gyp-bin/node/home/REDACTED/work/gh-aw/gh-aw/.github/workflows/agent-persona-explorer.md git(http block)/usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha --show-toplevel JE/ljgChBZHiD7WnPIlg48W/J-s6rDiV_9LLtYheNxUI /usr/bin/git 3774127002 go At,event,headBranch,headSha,disp--show-toplevel git 2602�� --show-toplevel node /usr/bin/git ErrorFormatting3node --write /usr/bin/git git(http block)https://api.github.com/repos/nonexistent/repo/actions/runs/12345/usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOSUMDB GOWORK run-script/lib/n--show-toplevel sh ode_�� k/gh-aw/gh-aw/.github/workflows/agent-performance-analyzer.md bash ache/node/24.13.0/x64/bin/node --noprofile node 64/bin/go git(http block)https://api.github.com/repos/owner/repo/actions/workflows/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go **/*.ts **/*.json --ignore-path node /hom�� --check scripts/**/*.js 64/bin/go .prettierignore format:cjs 64/bin/go go(http block)/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go **/*.ts **/*.json --ignore-path go env -json GOMOD 64/bin/go tierignore node 64/bin/go go(http block)/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go **/*.json --ignore-path ../../../.prettinpx prettier --check '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pr**/*.json sh -c "prettier" --wriGOSUMDB git 64/bin/go nPathSetup_Goroosh 64/pkg/tool/linu-c /usr/bin/git go(http block)https://api.github.com/repos/owner/repo/contents/file.md/tmp/go-build2155661420/b381/cli.test /tmp/go-build2155661420/b381/cli.test -test.testlogfile=/tmp/go-build2155661420/b381/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE node /opt�� prettier --check 64/bin/go --ignore-path .prettierignore 64/bin/go go(http block)/tmp/go-build2300498221/b381/cli.test /tmp/go-build2300498221/b381/cli.test -test.testlogfile=/tmp/go-build2300498221/b381/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true Secret: ${{ secrgo x_amd64/vet /usr/bin/git -diff 2>&1); \ GO111MODULE /opt�� prettier --write 64/bin/go !../../../pkg/wonode --ignore-path ../../../.pretti--check go(http block)/tmp/go-build1485461108/b381/cli.test /tmp/go-build1485461108/b381/cli.test -test.testlogfile=/tmp/go-build1485461108/b381/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/test-owner/test-repo/actions/secrets/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name npx prettier --cGOSUMDB GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go prettier --ch�� scripts/**/*.js --ignore-path 64/bin/go tierignore sh 64/bin/go go(http block)/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name --write **/*.cjs CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,CompiledGoFiles,Export,DepOnly,Imports,ImportMap,TestImports,XTestImpor **/*.json --ignore-path ../../../.prettirun sh -c "prettier" --wriGOSUMDB git 64/bin/go --show-toplevel 64/pkg/tool/linu-c /usr/bin/git go(http block)/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name .js' --ignore-path .prettierignore GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env ath ../../../.pr**/*.json GO111MODULE bin/node GOINSECURE GOMOD GOMODCACHE go(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>[step-names] Align "Upload charts" step names and fix compound/ambiguous step names across workflows</issue_title>
<issue_description>### Step Name Alignment Issues
Found across multiple
.github/workflows/*.lock.ymlfiles.Summary
Analysis of all
.lock.ymlfiles identified three categories of new step naming issues: a widespread inconsistency between"Upload charts"and"Upload generated charts"across 18 workflows, compound step names that violate single-responsibility naming, and inconsistent verbs for the lock file recompilation operation.Issues Identified
1. [High Priority] Inconsistency: "Upload charts" vs "Upload generated charts"
The established pattern for upload steps is
Upload (artifact). Across 18 workflows, two variants exist for the same operation:Using
"Upload charts"(6 workflows):audit-workflows.lock.ymldaily-firewall-report.lock.ymldaily-performance-summary.lock.ymlportfolio-analyst.lock.ymlprompt-clustering-analysis.lock.ymlstale-repo-identifier.lock.ymlUsing
"Upload generated charts"(12 workflows):copilot-pr-nlp-analysis.lock.ymlcopilot-session-insights.lock.ymldaily-code-metrics.lock.ymldaily-copilot-token-report.lock.ymldaily-issues-report.lock.ymldaily-news.lock.ymldaily-repo-chronicle.lock.ymlgithub-mcp-structural-analysis.lock.ymlorg-health-report.lock.ymlpython-data-charts.lock.ymlstale-repo-identifier.lock.yml(uses both!)weekly-issue-summary.lock.ymlIssue:
The word "generated" is redundant — charts are always generated before uploading. The established
Upload (artifact)pattern, used consistently across all other upload steps (Upload Safe Outputs,Upload agent artifacts,Upload prompt artifact, etc.), does not include process-describing adjectives.Note:
stale-repo-identifier.lock.ymluses both variants in different jobs, which is especially inconsistent.Suggested improvement:
Standardize on
"Upload charts"across all workflows.2. [Medium Priority] Compound Step Names Violating Single-Responsibility Naming
Three workflows use step names that describe two distinct operations joined by "and":
Current step names:
daily-news.lock.yml:"Setup directories and check cache"release.lock.yml:"Setup environment and fetch release data"ci-doctor.lock.yml:"Pre-download CI failure logs and artifacts, apply heuristics"Issue:
Step names should describe one action. Compound names obscure what the step does, make logs harder to scan, and the comma in the third example is especially unusual syntax for a step name. The
"Pre-download"verb prefix in the third is also non-standard — the established prefix for preparatory operations does not exist in other step names.Suggested improvements:
"Setup directories and check cache"→"Setup working directories"(cache check is implied by the setup)"Setup environment and fetch release data"→"Setup release environment"(or split into two steps)"Pre-download CI failure logs and artifacts, apply heuristics"→"Download CI failure logs and artifacts"(drop the comma+clause)3. [Medium Priority] Inconsistent Verbs: "Rebuild lock files" vs "Recompile workflows"
Two workflows performing the same conceptual operation — regenerating
.lock.ymlfiles from source.mdworkflows — use different verbs:Current step names:
ci-coach.lock.yml:"Rebuild lock files"daily-copilot-token-report.lock.yml:"Recompile workflows"Issue:
The project glossary defines this process as Compilation: "Translating Markdown workflows (
.mdfiles) into GitHub Actions YAML format (.lock.ymlfiles)". The verb"Recompile"aligns with the glossary term, while"Rebuild"does not. Neither workflow currently uses the most precise form.Suggested improvement:
Standardize on
"Recompile workflows"(aligned with the glossary's "Compilation" concept) for both workflows.Agentic Task Description
To improve these step names:
.mdfiles (not the.lock.ymlfiles directly)gh aw compile (workflow-name).mdto regenerate each.lock.ymlUpload (artifact)and single-verb patternsAll affected source files
Issue 1 — Standardize to "Upload charts":
.github/workflows/copilot-pr-nlp-analysis.md,.github/workflows/copilot-session-insights.md,.github/workflows/daily-code-metrics.md,.github/workflows/daily-copilot-token-report.md,.github/workflows/daily-issues-report.md,.github/workflows/daily-news.md, `.github/w...💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.