Skip to content

fix: remove incorrect build tag from checkout_manager.go#18253

Merged
pelikhan merged 2 commits intocopilot/add-checkout-field-and-managerfrom
copilot/fix-tests-2b38c6db-9852-4777-8e19-3f14737d75c2
Feb 25, 2026
Merged

fix: remove incorrect build tag from checkout_manager.go#18253
pelikhan merged 2 commits intocopilot/add-checkout-field-and-managerfrom
copilot/fix-tests-2b38c6db-9852-4777-8e19-3f14737d75c2

Conversation

Copy link
Contributor

Copilot AI commented Feb 25, 2026

Integration tests failed to build pkg/cli because checkout_manager.go — a production source file — was incorrectly tagged //go:build !integration, causing it to be excluded when running with -tags integration.

Change

  • Removed //go:build !integration from pkg/workflow/checkout_manager.go

This caused CheckoutConfig, ParseCheckoutConfigs, and NewCheckoutManager to be undefined during integration test compilation, failing every integration test job in CI.

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/22378884248/job/64781249369

Fix tests


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix tests in the codebase fix: remove incorrect build tag from checkout_manager.go Feb 25, 2026
@pelikhan pelikhan marked this pull request as ready for review February 25, 2026 04:03
Copilot AI review requested due to automatic review settings February 25, 2026 04:03
@pelikhan pelikhan merged commit 0527ce2 into copilot/add-checkout-field-and-manager Feb 25, 2026
@pelikhan pelikhan deleted the copilot/fix-tests-2b38c6db-9852-4777-8e19-3f14737d75c2 branch February 25, 2026 04:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an incorrect !integration build constraint from a production Go source file so pkg/cli can compile when running integration tests with -tags integration.

Changes:

  • Removed //go:build !integration from pkg/workflow/checkout_manager.go to ensure workflow checkout types/functions are available during integration-tagged builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants