Skip to content

fix: update TestGetActionPinsSorting expected pin count to 38 #18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 26, 2026
Merged

fix: update TestGetActionPinsSorting expected pin count to 38 #18438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
217e4ef
Initial plan
Copilot Feb 26, 2026
89797de
fix: update TestGetActionPinsSorting expected count from 37 to 38
Copilot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/workflow/action_pins_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,9 @@ func TestApplyActionPinToStep(t *testing.T) {
func TestGetActionPinsSorting(t *testing.T) {
pins := getActionPins()

// Verify we got all the pins (37 as of February 2026)
if len(pins) != 37 {
t.Errorf("getActionPins() returned %d pins, expected 37", len(pins))
// Verify we got all the pins (38 as of February 2026)
if len(pins) != 38 {
t.Errorf("getActionPins() returned %d pins, expected 38", len(pins))
Comment on lines +300 to +302
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test hard-codes both the pin count and a date in the comment, which will require churn every time a pin is legitimately added/removed. Since the expected count is already present in the embedded JSON, consider unmarshaling actionPinsJSON in the test and asserting len(getActionPins()) == len(data.Entries) (or dropping the exact-count assertion and just validating non-zero + sorting/fields).

Copilot uses AI. Check for mistakes.
}

// Verify they are sorted by version (descending) then by repository name (ascending)
Expand Down