fix: remove stale --verbose local flag check from TestNewPRTransferSubcommand#18442
Merged
pelikhan merged 2 commits intocopilot/add-action-pin-sha-resolutionfrom Feb 26, 2026
Merged
Conversation
…global persistent flag Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing test case in action workflow
fix: remove stale --verbose local flag check from TestNewPRTransferSubcommand
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the stale --verbose flag check from TestNewPRTransferSubcommand after commit bc5c864 moved the --verbose flag from individual subcommand local flags to a global persistent flag on the root command.
Changes:
- Removed the incorrect
--verboselocal flag assertion from the PR transfer subcommand test, since--verboseis now inherited as a persistent flag from the root command and is not registered in the subcommand's local FlagSet
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
bc5c86454moved--verbose/-vfrom a local flag on each subcommand to a global persistent flag on the root command (rootCmd.PersistentFlags().BoolVarP), but forgot to updateTestNewPRTransferSubcommand. The test calledcmd.Flags().Lookup("verbose")on a standalone subcommand (no parent), which never sees inherited persistent flags, causing CI to fail when merging against main.Changes
pkg/cli/pr_command_test.go: Remove the--verboselocal flag assertion fromTestNewPRTransferSubcommand. Since--verboseis now a root-level persistent flag, it is not registered on thetransfersubcommand's localFlagSetand the check was incorrect.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/actions/github-script/git/ref/tags/v8/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha runs/20260226-034940-13006/test-3238287890 /tmp/go-build374851768/b144/vet.cfg /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet l(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha runs/20260226-034940-13006/test-798266428/.github/workflows /tmp/go-build374851768/b155/vet.cfg Name,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle l -nolocalimports -importcfg /opt/hostedtoolcache/go/1.25.0/xstatus -ato�� -bool -buildtags /usr/bin/git -errorsas -ifaceassert -nilfunc git(http block)https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts/usr/bin/gh gh run download 1 --dir test-logs/run-1(http block)/usr/bin/gh gh run download 1 --dir test-logs/run-1 credential.username ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 1 --dir test-logs/run-1 x_amd64/vet 64/pkg/tool/linux_amd64/asm(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts/usr/bin/gh gh run download 12345 --dir test-logs/run-12345(http block)/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 --local ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet pull.rebase(http block)/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 x_amd64/vet /usr/bin/git ew@v1.1.1/spew/bgit ew@v1.1.1/spew/ccheckout 64/pkg/tool/linu.github/workflows/test.md 0G/qeV14P9Pi5vOe9KKsTnd/9UW1Ehkq0aF5jKwNeg7P rev-�� --show-toplevel 64/pkg/tool/linux_amd64/compile 6c5e5e449c81ef5b747b4b9e07ba3c4ed7dce7dd46fdf44a-d _.a(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts/usr/bin/gh gh run download 12346 --dir test-logs/run-12346(http block)/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 851768/b135/vet.cfg ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet pull.rebase(http block)/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 x_amd64/vet /usr/bin/git fflib@v1.0.0/difgit(http block)https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts/usr/bin/gh gh run download 2 --dir test-logs/run-2(http block)/usr/bin/gh gh run download 2 --dir test-logs/run-2 credential.username ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 2 --dir test-logs/run-2 x_amd64/vet 64/pkg/tool/linux_amd64/cgo(http block)https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts/usr/bin/gh gh run download 3 --dir test-logs/run-3(http block)/usr/bin/gh gh run download 3 --dir test-logs/run-3 credential.username ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 3 --dir test-logs/run-3 x_amd64/vet /usr/bin/git(http block)https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts/usr/bin/gh gh run download 4 --dir test-logs/run-4(http block)/usr/bin/gh gh run download 4 --dir test-logs/run-4 851768/b153/vet.cfg ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 4 --dir test-logs/run-4 x_amd64/vet 64/pkg/tool/linux_amd64/vet(http block)https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts/usr/bin/gh gh run download 5 --dir test-logs/run-5(http block)/usr/bin/gh gh run download 5 --dir test-logs/run-5 851768/b151/vet.cfg ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh run download 5 --dir test-logs/run-5 x_amd64/vet 64/pkg/tool/linux_amd64/link(http block)https://api.github.com/repos/github/gh-aw/actions/workflows/usr/bin/gh gh workflow list --json name,state,path(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6(http block)https://api.github.com/repos/nonexistent/repo/actions/runs/12345/usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion(http block)https://api.github.com/repos/owner/repo/actions/workflows/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo(http block)/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/pkg/tool/linux_amd64/vet(http block)/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo /usr/bin/git(http block)https://api.github.com/repos/owner/repo/contents/file.md/tmp/go-build452574309/b001/cli.test /tmp/go-build452574309/b001/cli.test -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.count=1(http block)/tmp/go-build633143880/b001/cli.test /tmp/go-build633143880/b001/cli.test -test.testlogfile=/tmp/go-build633143880/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.short=true -test.run=Test ution 64/pkg/tool/linux_amd64/vet(http block)/tmp/go-build4225123675/b001/cli.test /tmp/go-build4225123675/b001/cli.test -test.paniconexit0 -test.count=1 -test.timeout=2m0s -C /tmp/gh-aw-test-runs/20260226-034940-13006/test-1343527161/.github/workflows config /usr/bin/git remote.origin.urbash(http block)https://api.github.com/repos/test-owner/test-repo/actions/secrets/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name(http block)/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name /tmp/compile-all-instructions-test-749147983/.github/workflows rev-parse /usr/bin/git(http block)/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name 411917/b059/vet.cfg x_amd64/vet ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet --show-toplevel x_amd64/vet ndor/bin/bash ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.