Fix GITHUB_AW_AGENT_OUTPUT file path handling in safe output scripts#1877
Merged
Fix GITHUB_AW_AGENT_OUTPUT file path handling in safe output scripts#1877
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update JavaScript safe output scripts to parse JSON from file
Fix GITHUB_AW_AGENT_OUTPUT file path handling in safe output scripts
Oct 17, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
Collaborator
|
@copilot always assume the env var is a file, no backward compatibilty behavior. |
Contributor
Author
…file path Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…t output Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After commit 4a874cd ("Fix empty GITHUB_AW_AGENT_OUTPUT in safe output jobs", Oct 17 2025), safe output jobs began failing with JSON parse errors. The root cause:
GITHUB_AW_AGENT_OUTPUTchanged from containing JSON content directly to containing a file path (/tmp/gh-aw/safe-outputs/agent_output.json), but the JavaScript scripts still expected JSON and calledJSON.parse()directly on the file path string.Error example:
Changes
Updated all 11 safe output JavaScript files to always treat
GITHUB_AW_AGENT_OUTPUTas a file path:Before:
After:
Files Modified
All safe output JavaScript runners:
add_comment.cjsadd_labels.cjscreate_code_scanning_alert.cjscreate_discussion.cjscreate_issue.cjscreate_pr_review_comment.cjscreate_pull_request.cjsmissing_tool.cjspush_to_pull_request_branch.cjsupdate_issue.cjsupload_assets.cjsTest Updates
Updated all test files to write data to temporary files before setting the environment variable:
setAgentOutput(data)helper function to each test fileGITHUB_AW_AGENT_OUTPUTto the file pathafterEachhooks to remove temporary filesTesting
Implementation
The implementation always assumes
GITHUB_AW_AGENT_OUTPUTcontains a file path. No backward compatibility checks are performed.Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.