Skip to content

🧹 Remove dead script stubs and utility functions across packages #18846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 6 commits into from
Feb 28, 2026
Merged

🧹 Remove dead script stubs and utility functions across packages #18846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62477db
docs: update DEADCODE.md with console_wasm.go pitfall note
dsyme Feb 28, 2026
fed3700
dead12: remove dead utility functions from 7 packages
dsyme Feb 28, 2026
13914cf
dead13: remove dead functions from parser and workflow packages
dsyme Feb 28, 2026
5b55ade
dead14: remove dead functions from parser package
dsyme Feb 28, 2026
d3fa8ae
Merge branch 'main' of https://github.com/github/gh-aw into dead15
dsyme Feb 28, 2026
30ec6bf
dead15: remove dead get*Script() stubs from js.go
dsyme Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workflow/add_comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (c *Compiler) buildCreateOutputAddCommentJob(data *WorkflowData, mainJobNam
StepID: "add_comment",
MainJobName: mainJobName,
CustomEnvVars: customEnvVars,
Script: getAddCommentScript(),
Script: "",
Permissions: permissions,
Outputs: outputs,
Condition: jobCondition,
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/compiler_safe_outputs_specialized.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func (c *Compiler) buildCreateProjectStepConfig(data *WorkflowData, mainJobName
StepName: "Create Project",
StepID: "create_project",
ScriptName: "create_project",
Script: getCreateProjectScript(),
Script: "",
CustomEnvVars: customEnvVars,
Condition: condition,
Token: effectiveToken,
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/create_code_scanning_alert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func (c *Compiler) buildCreateOutputCodeScanningAlertJob(data *WorkflowData, mai
StepID: "create_code_scanning_alert",
MainJobName: mainJobName,
CustomEnvVars: customEnvVars,
Script: getCreateCodeScanningAlertScript(),
Script: "",
Permissions: NewPermissionsContentsReadSecurityEventsWriteActionsRead(),
Outputs: outputs,
Condition: jobCondition,
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/create_discussion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (c *Compiler) buildCreateOutputDiscussionJob(data *WorkflowData, mainJobNam
StepID: "create_discussion",
MainJobName: mainJobName,
CustomEnvVars: customEnvVars,
Script: getCreateDiscussionScript(),
Script: "",
Permissions: NewPermissionsContentsReadIssuesWriteDiscussionsWrite(),
Outputs: outputs,
Needs: needs,
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/create_pr_review_comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (c *Compiler) buildCreateOutputPullRequestReviewCommentJob(data *WorkflowDa
StepID: "create_pr_review_comment",
MainJobName: mainJobName,
CustomEnvVars: customEnvVars,
Script: getCreatePRReviewCommentScript(),
Script: "",
Permissions: NewPermissionsContentsReadPRWrite(),
Outputs: outputs,
Condition: jobCondition,
Expand Down
16 changes: 4 additions & 12 deletions pkg/workflow/js.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,10 @@ func init() {

// All getter functions return empty strings since embedded scripts were removed

func getAddCommentScript() string { return "" }
func getAssignToAgentScript() string { return "" }
func getCreateCodeScanningAlertScript() string { return "" }
func getCreateDiscussionScript() string { return "" }
func getCreateIssueScript() string { return "" }

//nolint:unused // Only used in integration tests
func getCreatePRReviewCommentScript() string { return "" }
func getNoOpScript() string { return "" }
func getNotifyCommentErrorScript() string { return "" }
func getCreateProjectScript() string { return "" }
func getUploadAssetsScript() string { return "" }
func getAssignToAgentScript() string { return "" }
func getNoOpScript() string { return "" }
func getNotifyCommentErrorScript() string { return "" }
func getUploadAssetsScript() string { return "" }
Comment on lines 68 to +73
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment All getter functions return empty strings... is now inaccurate/misleading: this file still has getters like GetLogParserScript returning a non-empty placeholder, and only a small subset of private get*Script() stubs remain below. Suggest rewording to something more precise (e.g., specifically about the remaining private get*Script() stubs) to avoid confusion for future maintainers.

See below for a potential fix:

// Private get*Script stubs return empty strings now that embedded scripts were removed.

func getAssignToAgentScript() string      { return "" }
func getNoOpScript() string               { return "" }
func getNotifyCommentErrorScript() string { return "" }
func getUploadAssetsScript() string       { return "" }

// Public Get* functions no longer return embedded script contents; most return empty
// strings or placeholders because scripts are provided at runtime instead.

Copilot uses AI. Check for mistakes.

// Public Get* functions return empty strings since embedded scripts were removed

Expand Down
Loading