[log] Add debug logging to parser, workflow, and cli packages#19110
Merged
[log] Add debug logging to parser, workflow, and cli packages#19110
Conversation
Enhance five files with meaningful debug logging to improve troubleshooting: - pkg/parser/schedule_cron_detection.go: log cron classification results (daily/hourly) and invalid expression detection - pkg/parser/import_cycle.go: log DFS cycle detection traversal using existing importLog, including cycle path discovery - pkg/parser/schema_compiler.go: log schema selection and validation outcomes in validateWithSchema using schemaCompilerLog - pkg/workflow/codex_mcp.go: log TOML and JSON MCP config rendering for custom tools with rewrite_localhost context using codexMCPLog - pkg/cli/deps_report.go: log go.mod parsing and JSON report generation using depsReportLog Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pelikhan
approved these changes
Mar 1, 2026
pelikhan
deleted the
add-debug-logging-to-parser-workflow-cli-33268f495d8cdfd3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance five files with meaningful debug logging to improve troubleshooting and developer visibility. All changes use existing named loggers where available and follow the project's
pkg:filenamenaming convention.Changes
pkg/parser/schedule_cron_detection.go— uses package-levellogfromfrontmatter.goIsDailyCron: log when a cron expression is classified as daily (minute/hour values)IsHourlyCron: log when a cron expression is classified as hourlyIsCronExpression: log when input is rejected due to incorrect field countpkg/parser/import_cycle.go— uses existingimportLogfromimport_processor.gofindCyclePath: log cycle node count, DFS start node, found path, and fallback casedfsForCycle: log when the cycle back-edge is detected (current -> target)pkg/parser/schema_compiler.go— uses existingschemaCompilerLogvalidateWithSchema: log context and field count on entry, which cached schema is selected, validation failure details, and success confirmationpkg/workflow/codex_mcp.go— uses existingcodexMCPLogrenderCodexMCPConfigWithContext: log tool name and localhost-rewrite flag before TOML rendering; log errorsrenderCodexJSONMCPConfigWithContext: log tool name,isLast, and localhost-rewrite flag before JSON rendering; log errorspkg/cli/deps_report.go— uses existingdepsReportLogparseGoModWithIndirect: log file path on entry and parsed dependency count on exitDisplayDependencyReportJSON: log summary counts before generating JSON outputQuality checklist
make buildpasses (no compilation errors)go test ./pkg/parser/...passesgo vet ./pkg/parser/... ./pkg/workflow/... ./pkg/cli/...passes🤖 Generated with [Claude Code]((claude.com/redacted)