Conversation
Remove 4 unreachable functions: - ParseRunURL (github_urls.go) - GitHubURLComponents.GetRepoSlug (github_urls.go) - GitHubURLComponents.GetWorkflowName (github_urls.go) - GetMainWorkflowSchema (schema_compiler.go) Also remove their exclusive tests.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a set of confirmed-unreferenced helper APIs related to GitHub run URL parsing and workflow schema access as part of the ongoing dead-code cleanup.
Changes:
- Removed
ParseRunURLconvenience wrapper and related CLI test coverage. - Removed
GitHubURLComponentshelpers (GetRepoSlug,GetWorkflowName) and their unit tests. - Removed exported
GetMainWorkflowSchemaaccessor (schema remains embedded and used internally).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/parser/schema_compiler.go | Drops the exported schema getter; schema continues to be referenced internally via mainWorkflowSchema. |
| pkg/parser/github_urls.go | Removes dead exported parsing/helper functions and the now-unused filepath import. |
| pkg/parser/github_urls_test.go | Removes tests for deleted GitHubURLComponents helper methods. |
| pkg/cli/audit_test.go | Removes ParseRunURL tests and the now-unused parser import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 4 unreachable functions: ParseRunURL, GetRepoSlug, GetWorkflowName, GetMainWorkflowSchema. Part of dead code cleanup.