-
Notifications
You must be signed in to change notification settings - Fork 298
Add --no-compile flag to update and upgrade commands #19325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -481,7 +481,7 @@ type latestReleaseResult struct { | |
| // major version. Updated files are recompiled. By default all actions are updated to | ||
| // the latest major version; pass disableReleaseBump=true to only update core | ||
| // (actions/*) references. | ||
| func UpdateActionsInWorkflowFiles(workflowsDir, engineOverride string, verbose, disableReleaseBump bool) error { | ||
| func UpdateActionsInWorkflowFiles(workflowsDir, engineOverride string, verbose, disableReleaseBump bool, noCompile bool) error { | ||
| if workflowsDir == "" { | ||
| workflowsDir = getWorkflowsDir() | ||
| } | ||
|
|
@@ -528,10 +528,12 @@ func UpdateActionsInWorkflowFiles(workflowsDir, engineOverride string, verbose, | |
| fmt.Fprintln(os.Stderr, console.FormatSuccessMessage("Updated action references in "+d.Name())) | ||
| updatedFiles = append(updatedFiles, path) | ||
|
|
||
| // Recompile the updated workflow | ||
| if err := compileWorkflowWithRefresh(path, verbose, false, engineOverride, false); err != nil { | ||
| if verbose { | ||
| fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to recompile %s: %v", path, err))) | ||
| // Recompile the updated workflow (unless --no-compile is set) | ||
| if !noCompile { | ||
| if err := compileWorkflowWithRefresh(path, verbose, false, engineOverride, false); err != nil { | ||
| if verbose { | ||
| fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to recompile %s: %v", path, err))) | ||
|
Comment on lines
+531
to
+535
|
||
| } | ||
| } | ||
| } | ||
| return nil | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ Examples: | |
| ` + string(constants.CLIExtensionPrefix) + ` update repo-assist --major # Allow major version updates | ||
| ` + string(constants.CLIExtensionPrefix) + ` update --force # Force update even if no changes | ||
| ` + string(constants.CLIExtensionPrefix) + ` update --disable-release-bump # Update without force-bumping all action versions | ||
| ` + string(constants.CLIExtensionPrefix) + ` update --no-compile # Update without regenerating lock files | ||
| ` + string(constants.CLIExtensionPrefix) + ` update --dir custom/workflows # Update workflows in custom directory | ||
| ` + string(constants.CLIExtensionPrefix) + ` update --create-pull-request # Update and open a pull request`, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
|
|
@@ -56,6 +57,7 @@ Examples: | |
| stopAfter, _ := cmd.Flags().GetString("stop-after") | ||
| noMergeFlag, _ := cmd.Flags().GetBool("no-merge") | ||
| disableReleaseBump, _ := cmd.Flags().GetBool("disable-release-bump") | ||
| noCompile, _ := cmd.Flags().GetBool("no-compile") | ||
| createPRFlag, _ := cmd.Flags().GetBool("create-pull-request") | ||
| prFlagAlias, _ := cmd.Flags().GetBool("pr") | ||
| createPR := createPRFlag || prFlagAlias | ||
|
|
@@ -70,7 +72,7 @@ Examples: | |
| } | ||
| } | ||
|
|
||
| if err := RunUpdateWorkflows(args, majorFlag, forceFlag, verbose, engineOverride, workflowDir, noStopAfter, stopAfter, noMergeFlag, disableReleaseBump); err != nil { | ||
| if err := RunUpdateWorkflows(args, majorFlag, forceFlag, verbose, engineOverride, workflowDir, noStopAfter, stopAfter, noMergeFlag, disableReleaseBump, noCompile); err != nil { | ||
| return err | ||
| } | ||
|
|
||
|
|
@@ -92,6 +94,7 @@ Examples: | |
| cmd.Flags().String("stop-after", "", "Override stop-after value in the workflow (e.g., '+48h', '2025-12-31 23:59:59')") | ||
| cmd.Flags().Bool("no-merge", false, "Override local changes with upstream version instead of merging") | ||
| cmd.Flags().Bool("disable-release-bump", false, "Disable automatic major version bumps for all actions (only core actions/* are force-updated)") | ||
| cmd.Flags().Bool("no-compile", false, "Skip recompiling workflows (do not modify lock files)") | ||
| cmd.Flags().Bool("create-pull-request", false, "Create a pull request with the update changes") | ||
| cmd.Flags().Bool("pr", false, "Alias for --create-pull-request") | ||
| _ = cmd.Flags().MarkHidden("pr") // Hide the short alias from help output | ||
|
|
@@ -106,12 +109,12 @@ Examples: | |
|
|
||
| // RunUpdateWorkflows updates workflows from their source repositories. | ||
| // Each workflow is compiled immediately after update. | ||
| func RunUpdateWorkflows(workflowNames []string, allowMajor, force, verbose bool, engineOverride string, workflowsDir string, noStopAfter bool, stopAfter string, noMerge bool, disableReleaseBump bool) error { | ||
| updateLog.Printf("Starting update process: workflows=%v, allowMajor=%v, force=%v, noMerge=%v, disableReleaseBump=%v", workflowNames, allowMajor, force, noMerge, disableReleaseBump) | ||
| func RunUpdateWorkflows(workflowNames []string, allowMajor, force, verbose bool, engineOverride string, workflowsDir string, noStopAfter bool, stopAfter string, noMerge bool, disableReleaseBump bool, noCompile bool) error { | ||
|
Comment on lines
110
to
+112
|
||
| updateLog.Printf("Starting update process: workflows=%v, allowMajor=%v, force=%v, noMerge=%v, disableReleaseBump=%v, noCompile=%v", workflowNames, allowMajor, force, noMerge, disableReleaseBump, noCompile) | ||
|
|
||
| var firstErr error | ||
|
|
||
| if err := UpdateWorkflows(workflowNames, allowMajor, force, verbose, engineOverride, workflowsDir, noStopAfter, stopAfter, noMerge); err != nil { | ||
| if err := UpdateWorkflows(workflowNames, allowMajor, force, verbose, engineOverride, workflowsDir, noStopAfter, stopAfter, noMerge, noCompile); err != nil { | ||
| firstErr = fmt.Errorf("workflow update failed: %w", err) | ||
| } | ||
|
|
||
|
|
@@ -125,7 +128,7 @@ func RunUpdateWorkflows(workflowNames []string, allowMajor, force, verbose bool, | |
|
|
||
| // Update action references in user-provided steps within workflow .md files. | ||
| // By default all org/repo@version references are updated to the latest major version. | ||
| if err := UpdateActionsInWorkflowFiles(workflowsDir, engineOverride, verbose, disableReleaseBump); err != nil { | ||
| if err := UpdateActionsInWorkflowFiles(workflowsDir, engineOverride, verbose, disableReleaseBump, noCompile); err != nil { | ||
| // Non-fatal: warn but don't fail the update | ||
| fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Warning: Failed to update action references in workflow files: %v", err))) | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc comment still states "Updated files are recompiled", but compilation is now optional via the
noCompileparameter. Please adjust the comment to reflect that recompilation is skipped when--no-compileis set.