Skip to content

fix: apply Prettier formatting to assign_agent_helpers.cjs #19501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 4, 2026
Merged

fix: apply Prettier formatting to assign_agent_helpers.cjs #19501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d3b1c
Initial plan
Copilot Mar 4, 2026
7f0458c
fix: run prettier on assign_agent_helpers.cjs to fix lint
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/setup/js/assign_agent_helpers.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ async function getPullRequestDetails(owner, repo, pullNumber) {
function logGraphQLErrorDetails(error, header, logFn) {
try {
if (!error || typeof error !== "object") return;
const err = /** @type {any} */ (error);
const err = /** @type {any} */ error;
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the parentheses from a JSDoc type cast breaks the cast entirely. In JSDoc, the correct syntax for a type cast/assertion is /** @type {T} */ (expr) — the parentheses are required for the cast to take effect. Without them, /** @type {any} */ error is just an inline comment and err retains its original type (unknown). As a result, accessing err.errors, err.response, and err.data further down will be flagged as errors by type checkers (TypeScript/Flow) in strict mode, since those properties don't exist on unknown.

Notice that line 422 uses the same pattern and has a // prettier-ignore comment specifically to prevent Prettier from removing these parentheses. The correct fix for line 250 is to add // prettier-ignore on the line before it, preserving the parenthesized cast, rather than letting Prettier strip the parentheses and silently break the type cast.

See below for a potential fix:

    // prettier-ignore
    const err = /** @type {any} */ (error);
    const details = {
      ...(err.errors && { errors: err.errors }),
      ...(err.response && { response: err.response }),
      ...(err.data && { data: err.data }),

Copilot uses AI. Check for mistakes.
const details = {
...(err.errors && { errors: err.errors }),
...(err.response && { response: err.response }),
Expand Down