Use MapToolConfig alias as return type for handlerBuilder#19583
Closed
Use MapToolConfig alias as return type for handlerBuilder#19583
MapToolConfig alias as return type for handlerBuilder#19583Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update handlerBuilder return type to MapToolConfig for consistency
Use Mar 4, 2026
MapToolConfig alias as return type for handlerBuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handlerBuilderwas returning the rawmap[string]anydespiteMapToolConfigexisting as a named alias for exactly this purpose inmcp_config_types.go.Changes
handlerBuildertypedef — return type changed frommap[string]anytoMapToolConfigBuild()onhandlerConfigBuilder— return type updated toMapToolConfig; internal field staysmap[string]anywith an explicit conversion at the return sitehandlerRegistry— declared return types updated to match the new typedefmake(map[string]any)→make(MapToolConfig)at the two sites that return empty configs to signal handler enablementWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/actions/checkout/git/ref/tags/v6/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha .js' --ignore-path .prettierigno-errorsas --local x_amd64/vet credential.userngit(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha get --local x_amd64/vet credential.userngit(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha get -authored-by: pelikhan <4175913+-ifaceassert tnet/tools/bash user.name(http block)https://api.github.com/repos/actions/download-artifact/git/ref/tags/v8/usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq .object.sha json' --ignore-path ../../../.pr**/*.json(http block)/usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq .object.sha ions-build/main.go(http block)/usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq .object.sha '**/*.ts' '**/*.json' --ignore-p-errorsas(http block)https://api.github.com/repos/actions/github-script/git/ref/tags/v8/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha .js' --ignore-path .prettierigno-errorsas --local x_amd64/vet credential.userngit(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha get --local x_amd64/vet credential.userninfocmp(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha tted" -authored-by: pelikhan <4175913+-ifaceassert 64/bin/bash user.name(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha .js' --ignore-path .prettierigno-errorsas --local x_amd64/vet credential.userngit(http block)https://api.github.com/repos/actions/setup-node/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha .js' --ignore-path .prettierigno-errorsas --local x_amd64/vet credential.userngh(http block)https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v7/usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha(http block)/usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha json' --ignore-path ../../../.pr**/*.json(http block)/usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha on' --ignore-path ../../../.pret.prettierignore(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
handlerBuilderreturn type toMapToolConfigfor consistency #19582🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.