Conversation
…generation.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move schema generation function to correct file
IMP-003: Move Mar 8, 2026
generateCustomJobToolDefinition to safe_outputs_config_generation.go
Contributor
There was a problem hiding this comment.
Pull request overview
Reorganizes safe-outputs schema generation code to satisfy conformance check IMP-003 by relocating generateCustomJobToolDefinition into the file where the architecture documentation expects it.
Changes:
- Moved
generateCustomJobToolDefinitionfromsafe_outputs_generation.gointo a dedicatedsafe_outputs_config_generation.go. - Removed the old implementation and section header from
safe_outputs_generation.go.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/safe_outputs_generation.go | Removes generateCustomJobToolDefinition from the large multipurpose generator file. |
| pkg/workflow/safe_outputs_config_generation.go | Adds generateCustomJobToolDefinition in the architecture-specified location for custom safe-output job tool schema generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conformance check IMP-003 requires
generateCustomJobToolDefinitionto live inpkg/workflow/safe_outputs_config_generation.go, matching the architecture documented insafe_outputs_config.go. The function was instead defined in the large multi-purposesafe_outputs_generation.go, causing IMP-003 to fail.Changes
pkg/workflow/safe_outputs_config_generation.go— extractsgenerateCustomJobToolDefinition(MCP tool schema builder for custom safe-output jobs) into its own dedicated file as specified by the conformance checker and the existing architecture docs.safe_outputs_generation.go.No functional changes — purely a file organization fix. The shared
safeOutputsConfigLoglogger (defined insafe_outputs_config.go) is accessible package-wide without changes.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.