[dead-code] chore: remove dead functions — 9 functions removed

[github-actions]

Dead Code Removal

This PR removes 9 unreachable Go functions identified by the deadcode static analyzer, which are unreachable from all production binary entry points.

Functions Removed

Function	File
renderSafeOutputsMCPConfig	pkg/workflow/mcp_config_builtin.go
renderCustomMCPConfigWrapper	pkg/workflow/mcp_config_custom.go
renderPlaywrightMCPConfig	pkg/workflow/mcp_config_playwright_renderer.go
getTypeString	pkg/workflow/mcp_config_validation.go
generatePlaywrightDockerArgs	pkg/workflow/mcp_playwright_config.go
generateRepoMemoryPushSteps	pkg/workflow/repo_memory.go
GenerateSafeInputGoToolScriptForInspector	pkg/workflow/safe_inputs_generator.go
IsSafeInputsHTTPMode	pkg/workflow/safe_inputs_parser.go
getSafeInputsEnvVars	pkg/workflow/safe_inputs_renderer.go

Tests Removed

Removed 11 test-only functions that exclusively tested the deleted functions:

• TestRenderSafeOutputsMCPConfigShared
• TestRenderCustomMCPConfigWrapperShared
• BenchmarkRenderPlaywrightMCPConfig
• BenchmarkGeneratePlaywrightDockerArgs
• BenchmarkRenderPlaywrightMCPConfig_Complex
• TestGetTypeString
• TestGetSafeInputsEnvVars
• TestGetSafeInputsEnvVarsStability
• TestRepoMemoryPushStepsGeneration
• TestParseSafeInputs
• TestParseSafeInputsAndExtractSafeInputsConfigConsistency

Verification

• ✅ go build ./... — passes
• ✅ go vet ./... — passes
• ✅ go vet -tags=integration ./... — passes
• ✅ make fmt — no changes needed
• ✅ All unit tests pass

Dead Function Count

• Before this batch: ~42 functions
• Removed in this PR: 9 functions
• Remaining: ~33 functions

---

Automated by Dead Code Removal workflow — https://github.com/github/gh-aw/actions/runs/22826569281

Generated by Dead Code Removal Agent · ◷

• expires on Mar 11, 2026, 6:12 PM UTC

[Copilot]

Pull request overview

This PR removes 9 dead Go functions identified by the deadcode static analyzer as unreachable from all production binary entry points, along with 11 test functions that exclusively tested those deleted functions.

Changes:

• Removes 9 unreachable production functions across 8 source files in pkg/workflow
• Removes 11 test/benchmark functions from 7 test files that exclusively covered the deleted production functions
• Updates one test (TestSafeInputsTimeoutParsing) to use extractSafeInputsConfig (the surviving method) instead of the now-deleted ParseSafeInputs standalone function

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/workflow/mcp_config_builtin.go	Removes renderSafeOutputsMCPConfig (dead wrapper for renderSafeOutputsMCPConfigWithOptions)
pkg/workflow/mcp_config_custom.go	Removes renderCustomMCPConfigWrapper (dead wrapper; context-aware version remains)
pkg/workflow/mcp_config_playwright_renderer.go	Removes renderPlaywrightMCPConfig (dead wrapper for renderPlaywrightMCPConfigWithOptions)
pkg/workflow/mcp_config_validation.go	Removes getTypeString (dead helper)
pkg/workflow/mcp_playwright_config.go	Removes generatePlaywrightDockerArgs (dead Docker args factory)
pkg/workflow/repo_memory.go	Removes generateRepoMemoryPushSteps (dead push step generator)
pkg/workflow/safe_inputs_generator.go	Removes GenerateSafeInputGoToolScriptForInspector (dead public wrapper; private impl remains)
pkg/workflow/safe_inputs_parser.go	Removes ParseSafeInputs (dead standalone function) and IsSafeInputsHTTPMode
pkg/workflow/safe_inputs_renderer.go	Removes getSafeInputsEnvVars (dead env-var collector)
pkg/workflow/mcp_config_shared_test.go	Removes tests for renderSafeOutputsMCPConfig and renderCustomMCPConfigWrapper
pkg/workflow/mcp_config_utils_test.go	Removes TestGetTypeString
pkg/workflow/mcp_benchmark_test.go	Removes benchmarks for deleted Playwright functions
pkg/workflow/repo_memory_test.go	Removes TestRepoMemoryPushStepsGeneration
pkg/workflow/safe_inputs_parser_test.go	Removes tests for ParseSafeInputs; leaves orphaned comment
pkg/workflow/safe_inputs_renderer_test.go	Removes tests for getSafeInputsEnvVars
pkg/workflow/safe_inputs_timeout_test.go	Updates test to use extractSafeInputsConfig instead of removed ParseSafeInputs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.