Skip to content

[log] Add debug logging to MCP inspection, workflow resolution, and repo memory#20119

Merged
pelikhan merged 1 commit intomainfrom
log/add-debug-logging-mcp-workflow-resolution-9807df6c36d5a82e
Mar 8, 2026
Merged

[log] Add debug logging to MCP inspection, workflow resolution, and repo memory#20119
pelikhan merged 1 commit intomainfrom
log/add-debug-logging-mcp-workflow-resolution-9807df6c36d5a82e

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2026

Adds meaningful debug log statements to five files that had minimal logging relative to their complexity.

Changes

  • cli:add_workflow_resolution — log repo slug detection result, per-workflow resolution details (engine, dispatch trigger, content size), and final resolved counts
  • workflow:compiler_workflow_call — log workflow_call output injection entry, safe-output type configuration, generated output count, and merged output count
  • cli:mcp_inspect — log parsed workflow name/safe-inputs presence, MCP config counts before/after filtering, and safe-inputs server start/failure status
  • cli:mcp_list_tools — log MCP config search results, found/not-found server details, and connected tool count
  • workflow:repo_memory_prompt — log constraint configuration, wiki mode enabled, final built section details for both single and multi-memory paths, and extension union set building

Validation

  • make build passed
  • go build ./... passed
  • go vet ./... passed

Generated by Go Logger Enhancement ·

  • expires on Mar 10, 2026, 8:26 PM UTC

…mory

Adds meaningful debug log statements to five files that had minimal or
no logging relative to their complexity:

- cli:add_workflow_resolution - log repo slug detection, each resolved
  workflow (engine, dispatch trigger, content size), and final counts
- workflow:compiler_workflow_call - log workflow_call output injection
  entry, what safe-output types are configured, and merged output count
- cli:mcp_inspect - log parsed workflow name/safe-inputs, MCP config
  counts before/after filtering, and safe-inputs server start status
- cli:mcp_list_tools - log MCP config search results, found/not-found
  server details, and connected tool count
- workflow:repo_memory_prompt - log constraint configuration, wiki mode,
  and final built section details for both single and multi-memory paths

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added automation enhancement New feature or request labels Mar 8, 2026
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 8, 2026

Hey @github-actions 👋 — great addition! Sprinkling structured debug logging across add_workflow_resolution, mcp_inspect, mcp_list_tools, compiler_workflow_call, and repo_memory_prompt will make it much easier to trace execution through these complex subsystems.

One thing worth addressing before merge:

  • Test suite confirmation missing — the PR validation block shows make build, go build ./..., and go vet ./... passing, but there's no confirmation that go test ./... (or make agent-finish) was run and passed. While the logging additions themselves don't require new tests, the CONTRIBUTING guidelines require that make agent-finish — which includes the full test suite — is run before completing a PR. Please confirm existing tests still pass with the new log calls in place (particularly for pkg/workflow/compiler_workflow_call.go and pkg/workflow/repo_memory_prompt.go, which have unit tests adjacent to the changed code).

If you'd like a hand, you can assign this prompt to your coding agent:

In the gh-aw repository, confirm the test suite passes after the debug logging additions in PR #20119.

Steps:
1. Run `make agent-finish` (or at minimum `go test ./pkg/cli/... ./pkg/workflow/...`) and verify all tests pass.
2. If any tests fail due to the new log calls (e.g., log variable not initialised in a test binary), fix the initialisation.
3. Update the PR validation section in the PR body to include `go test ./...` or `make agent-finish` output confirming a clean run.

Generated by Contribution Check ·

@pelikhan pelikhan merged commit 5f8ffaf into main Mar 8, 2026
@pelikhan pelikhan deleted the log/add-debug-logging-mcp-workflow-resolution-9807df6c36d5a82e branch March 8, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant