Skip to content

fix(safe-outputs): include pull_request_target in PR context detection #20198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 9, 2026
Merged

fix(safe-outputs): include pull_request_target in PR context detection #20198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461991e
Initial plan
Copilot Mar 9, 2026
27d28b3
fix: include pull_request_target in PR context detection for safe-out…
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/setup/js/safe_output_helpers.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function resolveTarget(params) {

// Check context type
const isIssueContext = context.eventName === "issues" || context.eventName === "issue_comment";
const isPRContext = context.eventName === "pull_request" || context.eventName === "pull_request_review" || context.eventName === "pull_request_review_comment";
const isPRContext = context.eventName === "pull_request" || context.eventName === "pull_request_target" || context.eventName === "pull_request_review" || context.eventName === "pull_request_review_comment";

// Default target is "triggering"
const target = targetConfig || "triggering";
Expand Down
26 changes: 26 additions & 0 deletions actions/setup/js/safe_output_helpers.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,19 @@ describe("safe_output_helpers", () => {
expect(result.contextType).toBe("pull request");
});

it("should handle pull_request_target event", () => {
const result = helpers.resolveTarget({
...baseParams,
context: {
eventName: "pull_request_target",
payload: { pull_request: { number: 654 } },
},
});
expect(result.success).toBe(true);
expect(result.number).toBe(654);
expect(result.contextType).toBe("pull request");
});

it("should fail when issue context but no issue in payload", () => {
const result = helpers.resolveTarget({
...baseParams,
Expand Down Expand Up @@ -246,6 +259,19 @@ describe("safe_output_helpers", () => {
expect(result.contextType).toBe("pull request");
});

it("should resolve triggering pull_request_target context", () => {
const result = helpers.resolveTarget({
...baseParams,
context: {
eventName: "pull_request_target",
payload: { pull_request: { number: 987 } },
},
});
expect(result.success).toBe(true);
expect(result.number).toBe(987);
expect(result.contextType).toBe("pull request");
});

it("should fail when triggering and not in PR context", () => {
const result = helpers.resolveTarget({
...baseParams,
Expand Down
Loading