Rename threat detection artifact from threat-detection.log to detection#20541
Rename threat detection artifact from threat-detection.log to detection#20541
threat-detection.log to detection#20541Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
threat-detection.log to detection
|
@copilot updates the logs and audit command to handle the new artifact name |
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | ||
| with: | ||
| name: threat-detection.log | ||
| name: detection |
There was a problem hiding this comment.
The artifact name change from threat-detection.log to detection is cleaner and avoids confusion between the artifact name and file extension. Good naming improvement!
There was a problem hiding this comment.
Indeed! The rename is much cleaner for artifact consumers. 🎉
📰 BREAKING: Report filed by Smoke Copilot
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | ||
| with: | ||
| name: threat-detection.log | ||
| name: detection |
There was a problem hiding this comment.
Consistent rename across all lock files. This is a good systematic change - the new name detection is more concise and doesn't mislead consumers about the artifact content type.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 1822c9f. Added |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
Agent Container Tool Check
Result: 12/12 tools available ✅ — PASS
|
|
Commit pushed:
|
Smoke Test (Codex)PR titles: Merge agent job artifacts into single
Warning
|
|
Smoke Test §22965354468 —
Status:
|
There was a problem hiding this comment.
PR renames threat-detection.log artifact to detection across all lock files, and adds actions/download-artifact@v8 to the actions lock. Clean, consistent change with proper SHA pinning.
📰 BREAKING: Report filed by Smoke Copilot
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | ||
| with: | ||
| name: threat-detection.log | ||
| name: detection |
There was a problem hiding this comment.
Renaming from threat-detection.log to detection is cleaner. This change is consistently applied across all lock files - good housekeeping!
| "actions/download-artifact@v8": { | ||
| "repo": "actions/download-artifact", | ||
| "version": "v8", | ||
| "sha": "3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c" |
There was a problem hiding this comment.
Good addition of the actions/download-artifact@v8 entry with SHA pinning. Using the SHA (3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c) is a security best practice for pinning action versions.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results — Run §22965354532Status: PARTIAL (2 skipped)
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
There was a problem hiding this comment.
Pull request overview
Renames the threat-detection upload artifact from threat-detection.log to detection, and introduces constants + tests to keep artifact downloads compatible across old/new directory names.
Changes:
- Update workflow compilation to upload the detection log artifact under the new artifact name (
detection). - Add
DetectionArtifactName/LegacyDetectionArtifactNameconstants and update unit tests to use them. - Regenerate compiled workflow lock files to reflect the new artifact name.
Reviewed changes
Copilot reviewed 161 out of 161 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/threat_detection.go | Uses constants.DetectionArtifactName when generating the upload-artifact step for the detection log. |
| pkg/workflow/threat_detection_test.go | Updates expectations for the artifact name in threat detection step generation. |
| pkg/constants/constants.go | Adds new/legacy detection artifact name constants for reuse across the codebase. |
| pkg/cli/logs_artifact_compat_test.go | Adds compatibility tests ensuring both old/new artifact directory names flatten to detection.log. |
| .github/aw/actions-lock.json | Adds an actions/download-artifact@v8 pin entry used by regenerated lock workflows. |
| .changeset/patch-rename-detection-artifact.md | Adds a patch changeset documenting the artifact rename + compatibility. |
| .github/workflows/agent-performance-analyzer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/agent-persona-explorer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/archie.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/artifacts-summary.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/audit-workflows.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/auto-triage-issues.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/blog-auditor.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/brave.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/breaking-change-checker.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/changeset.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/ci-coach.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/ci-doctor.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/cli-consistency-checker.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/cli-version-checker.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/cloclo.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/code-scanning-fixer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/code-simplifier.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/commit-changes-analyzer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/constraint-solving-potd.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/contribution-check.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/copilot-agent-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/copilot-session-insights.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/craft.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-architecture-diagram.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-assign-issue-to-user.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-choice-test.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-cli-performance.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-code-metrics.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-compiler-quality.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-copilot-token-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-doc-healer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-doc-updater.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-fact.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-file-diet.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-firewall-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-issues-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-multi-device-docs-tester.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-news.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-observability-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-performance-summary.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-regulatory.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-rendering-scripts-verifier.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-repo-chronicle.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-safe-outputs-conformance.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-secrets-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-security-red-team.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-semgrep-scan.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-team-evolution-insights.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-team-status.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/daily-workflow-updater.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/dead-code-remover.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/deep-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/delight.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/dependabot-burner.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/dependabot-go-checker.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/dev-hawk.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/dev.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/developer-docs-consolidator.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/dictation-prompt.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/discussion-task-miner.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/docs-noob-tester.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/draft-pr-cleanup.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/duplicate-code-detector.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/example-workflow-analyzer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/firewall-escape.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/functional-pragmatist.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/github-mcp-tools-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/github-remote-mcp-auth-test.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/glossary-maintainer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/go-fan.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/go-logger.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/go-pattern-detector.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/gpclean.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/grumpy-reviewer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/instructions-janitor.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/issue-arborist.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/issue-monster.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/issue-triage-agent.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/jsweep.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/layout-spec-maintainer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/lockfile-stats.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/mcp-inspector.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/mergefest.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/org-health-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/pdf-summary.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/plan.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/poem-bot.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/portfolio-analyst.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/pr-triage-agent.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/python-data-charts.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/q.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/refiner.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/release.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/repo-audit-analyzer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/repo-tree-map.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/repository-quality-improver.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/research.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/safe-output-health.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/schema-consistency-checker.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/scout.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/security-alert-burndown.campaign.g.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/security-compliance.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/security-review.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/semantic-function-refactor.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/sergo.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/slide-deck-maintainer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-agent.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-claude.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-codex.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-copilot-arm.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-copilot.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-create-cross-repo-pr.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-gemini.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-multi-pr.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-project.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-temporary-id.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-test-tools.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-update-cross-repo-pr.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/smoke-workflow-call.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/stale-repo-identifier.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/static-analysis-report.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/step-name-alignment.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/sub-issue-closer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/super-linter.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/technical-doc-writer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/terminal-stylist.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/test-create-pr-error-handling.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/test-dispatcher.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/test-project-url-default.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/tidy.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/typist.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/unbloat-docs.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/video-analyzer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/weekly-editors-health-check.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/weekly-issue-summary.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/weekly-safe-outputs-spec-review.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/workflow-generator.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/workflow-health-manager.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/workflow-normalizer.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
| .github/workflows/workflow-skill-extractor.lock.yml | Regenerated workflow lock with detection artifact name updated to detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if !strings.Contains(stepsString, "detection") { | ||
| t.Error("Expected inline detection steps to include detection artifact name") |
There was a problem hiding this comment.
This assertion is too broad: stepsString contains many unrelated occurrences of "detection" (e.g., detection_guard, parse_detection_results), so the test can pass even if the upload-artifact with.name value regresses. Consider asserting on the exact artifact name line (e.g., name: + constants.DetectionArtifactName) and using the constant instead of a hard-coded string.
The upload artifact step in threat detection was using
threat-detection.logas the artifact name. This renames it todetection.Changes
pkg/workflow/threat_detection.go— UpdatedbuildUploadDetectionLogStepartifactnamefield fromthreat-detection.log→detection, now usingconstants.DetectionArtifactNamepkg/workflow/threat_detection_test.go— Updated test assertions to useconstants.DetectionArtifactNamepkg/constants/constants.go— AddedDetectionArtifactName = "detection"andLegacyDetectionArtifactName = "threat-detection.log"constants for use across the codebasepkg/cli/logs_artifact_compat_test.go— Added backward compatibility test cases verifying that both the oldthreat-detection.logand newdetectionartifact directory names are correctly flattened todetection.logwhen the logs/audit commands download and process artifacts.github/workflows/*.lock.yml— Regenerated all compiled lock files reflecting the new artifact nameOriginal prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.
✨ PR Review Safe Output Test - Run 22963390673
Rename threat detection artifact from
threat-detection.logtodetectionThe upload artifact step in threat detection was using
threat-detection.logas the artifact name. This renames it todetection.Changeset
threat-detection.logtodetectionand keep downloads compatible with both names.Warning
The following domains were blocked by the firewall during workflow execution:
ab.chatgpt.comgithub.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
✨ PR Review Safe Output Test - Run 22965354532