Skip to content

[code-simplifier] refactor: simplify default case in buildSafeOutputJobsEnvVars #20568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Mar 11, 2026
Merged

[code-simplifier] refactor: simplify default case in buildSafeOutputJobsEnvVars #20568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/workflow/notify_comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,13 +477,11 @@ func buildSafeOutputJobsEnvVars(jobNames []string) (string, []string) {
case "push_to_pull_request_branch":
urlKey = "commit_url"
default:
if systemSafeOutputJobNames[jobName] {
// Skip known system jobs — they are not custom safe output types
continue
if !systemSafeOutputJobNames[jobName] {
// Custom safe-output job: include in the mapping with an empty URL key so the
// handler manager can silently skip messages of this type.
jobOutputMapping[jobName] = ""
}
// Custom safe-output job: include in the mapping with an empty URL key so the
// handler manager can silently skip messages of this type.
jobOutputMapping[jobName] = ""
continue
}

Expand Down