fix: update TestGetActionPinsSorting expected count from 31 to 34 (#23057948566)#20824
Merged
fix: update TestGetActionPinsSorting expected count from 31 to 34 (#23057948566)#20824
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
March 13, 2026 16:18
View session
pelikhan
approved these changes
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a brittle unit test expectation to match the current number of embedded action pins, addressing a CI failure in TestGetActionPinsSorting.
Changes:
- Update
TestGetActionPinsSortingexpected pin count from 31 to 34.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+300
to
+302
| // Verify we got all the pins (34 as of March 2026) | ||
| if len(pins) != 34 { | ||
| t.Errorf("getActionPins() returned %d pins, expected 34", len(pins)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI test failure in https://github.com/github/gh-aw/actions/runs/23057948566/job/66976491837.
The test
TestGetActionPinsSortingwas failing becausegetActionPins()returned 34 pins but the test expected 31.Root Cause
Three new backward-compatible action pin entries were added to
action_pins.jsonin commitedd81b6df(foractions/cache/restore@v4,actions/cache/save@v4, andactions/setup-node@v4), bringing the total from 31 to 34. The test's hardcoded expected count was not updated to reflect this.Changes
TestGetActionPinsSortingfrom31to34action_pins.jsonto the correctorigin/mainstate (34 entries) that was incorrectly modified by the initial plan commitSecurity Summary
No security vulnerabilities introduced or discovered.