Skip to content

[WIP] [67003058781] Fix the failing GitHub Actions workflow test #20838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Mar 13, 2026
+13 −3
Merged

[WIP] [67003058781] Fix the failing GitHub Actions workflow test #20838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
222ab48
Initial plan
Copilot Mar 13, 2026
c02c57e
fix: make TestGetActionPinsSorting resilient to JSON pin count changes
Copilot Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions pkg/workflow/action_pins_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package workflow

import (
"bytes"
"encoding/json"
"os"
"regexp"
"strings"
Expand Down Expand Up @@ -297,9 +298,18 @@ func TestApplyActionPinToStep(t *testing.T) {
func TestGetActionPinsSorting(t *testing.T) {
pins := getActionPins()

// Verify we got all the pins (34 as of March 2026)
if len(pins) != 34 {
t.Errorf("getActionPins() returned %d pins, expected 34", len(pins))
// Dynamically derive the expected count from the JSON file to avoid
// hardcoding a number that breaks when new pins are added or when
// the Go test cache contains a stale binary.
Comment on lines +302 to +303
var jsonData ActionPinsData
if err := json.Unmarshal(actionPinsJSON, &jsonData); err != nil {
t.Fatalf("Failed to parse action_pins.json: %v", err)
}
expectedCount := len(jsonData.Entries)

// Verify we got all the pins from the JSON (catches parsing bugs)
if len(pins) != expectedCount {
t.Errorf("getActionPins() returned %d pins, expected %d (from action_pins.json)", len(pins), expectedCount)
}

// Verify they are sorted by version (descending) then by repository name (ascending)
Expand Down
Loading