fix: gh aw upgrade always corrects with: version: drift in copilot-setup-steps.yml#20896
Closed
fix: gh aw upgrade always corrects with: version: drift in copilot-setup-steps.yml#20896
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…eps.yml Use a pre-compiled pattern that matches any setup-cli uses: line (not anchored to the exact new ref) so that pre-existing drift between the uses: comment version and with: version: is always corrected on upgrade. Fixes #<issue> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
March 14, 2026 02:36
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh aw upgradeupdated theuses:SHA/comment but silently leftwith: version:stale whenever pre-existing drift existed between the two fields.Root cause:
upgradeSetupCliVersionInContentbuilt itsversionInWithPatternregex anchored to the exact newuses:value (escapedNewUses). Since the match was tied to the just-written ref string, any prior mismatch betweenuses:comment andwith: version:bypassed the version update entirely.Changes
pkg/cli/copilot_setup.go: Replace the runtime-compiled,escapedNewUses-anchoredversionInWithPatternwith a pre-compiledsetupCliVersionInWithPatternthat matches anysetup-cliuses:line (SHA-pinned, version tag, quoted, or unquoted). Thewith: version:update is now independent of the exact ref format.pkg/cli/copilot_setup_test.go: Add two regression cases covering the drift scenario — SHA-pinneduses:comment ahead of a stalewith: version:, and same with a version-tag ref.Before (broken when drift existed):
After: