Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/patch-disable-safe-outputs-http-timeouts.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion .github/workflows/draft-pr-cleanup.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion .github/workflows/poem-bot.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion .github/workflows/smoke-claude.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions actions/setup/js/safe_outputs_mcp_server_http.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,13 @@ async function startHttpServer(options = {}) {
}
});

// Disable all HTTP server timeouts to prevent idle connections from being dropped
// during long agent runs where safe-output tools may not be called for several minutes.
httpServer.timeout = 0;
httpServer.keepAliveTimeout = 0;
httpServer.headersTimeout = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting all timeouts to 0 (unlimited) is a broad approach. Consider using a very large value (e.g., 600000 for 10 minutes) instead of disabling timeouts entirely, to still protect against truly hung connections.

httpServer.requestTimeout = 0;

// Start listening
logger.debug(`Attempting to bind to port ${port}...`);
httpServer.listen(port, () => {
Expand Down
Loading