fix: align compiler-generated step names with glossary and verb conventions#20937
Closed
fix: align compiler-generated step names with glossary and verb conventions#20937
Conversation
…or MCP Scripts (#step-names) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
March 14, 2026 14:14
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes human-readable GitHub Actions step names in generated workflows (e.g., “Write …” instead of “Setup …”, and “agentic workflow” wording), and updates the committed lockfile workflows/docs accordingly.
Changes:
- Renamed MCP scripts steps from “Setup …” to “Write …” in the workflow generator output.
- Renamed lock/unlock issue step names to use “agentic workflow” terminology.
- Renamed the release workflow “Notify …” step to “Display release sync instructions” and updated the release lock metadata.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/mcp_setup_generator.go | Renames generated MCP scripts step names (“Setup” → “Write”). |
| pkg/workflow/compiler_unlock_job.go | Renames the unlock step label (“agent workflow” → “agentic workflow”). |
| pkg/workflow/compiler_activation_job.go | Renames the lock step label (“agent workflow” → “agentic workflow”). |
| .github/workflows/workflow-generator.lock.yml | Updates lock/unlock step names in generated workflow. |
| .github/workflows/unbloat-docs.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/technical-doc-writer.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/smoke-gemini.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/smoke-copilot.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/smoke-copilot-arm.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/smoke-codex.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/smoke-claude.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/release.md | Renames a documented release step label for clarity. |
| .github/workflows/release.lock.yml | Updates release step label and metadata hash in locked workflow. |
| .github/workflows/go-logger.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/glossary-maintainer.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/dictation-prompt.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/developer-docs-consolidator.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/daily-regulatory.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/daily-performance-summary.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/daily-doc-updater.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/daily-doc-healer.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/daily-cli-performance.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Updates MCP scripts step names in generated workflow. |
| .github/workflows/ai-moderator.lock.yml | Updates lock/unlock step names in generated workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| ) | ||
|
|
||
| steps = append(steps, " - name: Lock issue for agent workflow\n") | ||
| steps = append(steps, " - name: Lock issue for agentic workflow\n") |
| unlockCondition := BuildAnd(eventTypeCheck, lockedOutputCheck) | ||
|
|
||
| steps = append(steps, " - name: Unlock issue after agent workflow\n") | ||
| steps = append(steps, " - name: Unlock issue after agentic workflow\n") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three categories of step name inconsistencies in compiler-generated and source workflows: wrong terminology ("agent" vs "agentic"), wrong verb ("Setup" vs "Write") for file-writing steps, and a misleading step name in
release.md.Compiler changes
compiler_activation_job.go/compiler_unlock_job.go:"agent workflow"→"agentic workflow"in lock/unlock step names (glossary alignment)mcp_setup_generator.go:"Setup MCP Scripts Config"/"Setup MCP Scripts Tool Files"→"Write MCP Scripts Config"/"Write MCP Scripts Tool Files"(both steps write files via heredoc, consistent withWrite Safe Outputs Config)Source workflow change
release.mdline 197:"Notify - run sync actions and merge PR"→"Display release sync instructions"(step writes toGITHUB_STEP_SUMMARY, not a notification)All 173 workflows recompiled.