Conversation
…ent tool schema Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds support for specifying an explicit PR number when creating inline PR review comments, fixing cases where workflows target "*" (any PR) and the handler requires pull_request_number.
Changes:
- Added optional
pull_request_number(number | string) to thecreate_pull_request_review_commenttool JSON schema (source + runtime copies) and clarified the"target: \"*\""requirement in descriptions. - Updated Go safe-output validation config to allow/validate
pull_request_numberforcreate_pull_request_review_comment. - Regenerated/updated several workflow
*.lock.ymlfiles to reflect the tool schema + validation config changes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/safe_output_validation_config.go | Allows pull_request_number in validation rules for create_pull_request_review_comment. |
| pkg/workflow/js/safe_outputs_tools.json | Adds pull_request_number to the tool schema and updates the tool description. |
| actions/setup/js/safe_outputs_tools.json | Mirrors the schema + description updates for runtime usage. |
| .github/workflows/smoke-copilot.lock.yml | Updates embedded tools/validation config to include pull_request_number. |
| .github/workflows/smoke-copilot-arm.lock.yml | Same as above for ARM smoke workflow lock. |
| .github/workflows/smoke-claude.lock.yml | Same as above for Claude smoke workflow lock. |
| .github/workflows/security-review.lock.yml | Same as above for security-review workflow lock. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Same as above for nitpick reviewer workflow lock. |
| .github/workflows/poem-bot.lock.yml | Same as above for poem-bot workflow lock. |
| .github/workflows/grumpy-reviewer.lock.yml | Same as above for grumpy-reviewer workflow lock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "number", | ||
| "string" | ||
| ] | ||
| }, |
| "number", | ||
| "string" | ||
| ] | ||
| }, |
| "number", | ||
| "string" | ||
| ] | ||
| }, |
| "pull_request_number": { | ||
| "type": [ | ||
| "number", | ||
| "string" | ||
| ], |
| "pull_request_number": { | ||
| "type": ["number", "string"], | ||
| "description": "Pull request number to add the review comment to. This is the numeric ID from the GitHub URL (e.g., 876 in github.com/owner/repo/pull/876). If omitted, adds the comment to the PR that triggered this workflow. Required when the workflow target is '*' (any PR) — omitting it will cause the comment to fail." | ||
| }, |
| "number", | ||
| "string" | ||
| ] | ||
| }, |
| "number", | ||
| "string" | ||
| ] | ||
| }, |
| "number", | ||
| "string" | ||
| ] | ||
| }, |
| "number", | ||
| "string" | ||
| ] | ||
| }, |
|
@copilot review comments |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Added Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
pull_request_number to create_pull_request_review_comment tool schemapull_request_number and repo fields to create_pull_request_review_comment tool schema
create_pull_request_review_commentwas missingpull_request_numberandrepofrom its input schema. WithadditionalProperties: false, agents couldn't include these fields even when they were needed — the handler requirespull_request_numberwhentarget: "*"is configured, and supportsrepofor cross-repo targets, but both were blocked by the schema.Changes
pkg/workflow/js/safe_outputs_tools.json— Addedpull_request_number(number | string, optional) andrepo(string, optional) tocreate_pull_request_review_commentproperties; updated description to call out thetarget: "*"requirementactions/setup/js/safe_outputs_tools.json— Mirrored same changes to the runtime copypkg/workflow/safe_output_validation_config.go— Added"pull_request_number": {OptionalPositiveInteger: true}to align with other PR-targeting tools (update_pull_request,push_to_pull_request_branch,add_reviewer, etc.)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.