[code-simplifier] refactor: simplify lock file reading and project config string extraction

[github-actions]

Code simplification of recently merged PRs (#20951 and #20939).

Files Simplified

• pkg/cli/run_workflow_validation.go — extracted readLockFile() helper to eliminate ~30 lines of duplicated code
• pkg/workflow/project_config_parsing.go — replaced verbose multi-line string extraction with existing extractStringFromMap() helper (~27 lines removed)

Improvements Made

1. Extracted readLockFile() helper (run_workflow_validation.go)

IsRunnable and getWorkflowInputs shared identical logic for reading and parsing the compiled lock file:

• getLockFilePath + filepath.Clean
• os.Stat existence check with the same error message
• os.ReadFile with #nosec G304
• yaml.Unmarshal with identical error wrapping

Extracted into a single readLockFile(markdownPath string) (map[string]any, error) helper. Both callers now use it, preserving all debug logging.

2. Used extractStringFromMap() helper (project_config_parsing.go)

The new parseProjectViews and parseProjectFieldDefinitions functions (from PR #20939) used a verbose 4-line pattern to extract each string field:

if name, exists := viewMap["name"]; exists {
    if nameStr, ok := name.(string); ok {
        view.Name = nameStr
    }
}

extractStringFromMap() already exists in pkg/workflow/config_helpers.go for exactly this purpose. Changed to use struct initialization with single-line calls:

view := ProjectView{
    Name:        extractStringFromMap(viewMap, "name", nil),
    Layout:      extractStringFromMap(viewMap, "layout", nil),
    Filter:      extractStringFromMap(viewMap, "filter", nil),
    Description: extractStringFromMap(viewMap, "description", nil),
}

Changes Based On

• feat: improve run command error output for missing workflow inputs #20951 — feat: improve run command error output for missing workflow inputs
• refactor: extract shared project config parsing helpers to eliminate duplication #20939 — refactor: extract shared project config parsing helpers to eliminate duplication

Testing

• ✅ All relevant tests pass (TestValidateWorkflowInputs, TestParseProjectViews, TestParseProjectFieldDefinitions, etc.)
• ✅ Build succeeds (make build)
• ✅ go vet clean
• ✅ No functional changes — behavior is identical (net -57 lines)

Generated by Code Simplifier · ◷

• expires on Mar 15, 2026, 7:02 PM UTC

[pelikhan]

@copilot lint

[Copilot]

Pull request overview

Refactors recently added workflow validation and project config parsing logic to reduce duplication and simplify string extraction.

Changes:

• Extracted a shared readLockFile() helper to centralize lock file existence checks, reading, and YAML unmarshaling.
• Simplified project config parsing by using extractStringFromMap() for views and field-definitions string fields.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/workflow/project_config_parsing.go	Replaces manual string field extraction with extractStringFromMap() and keeps required-field filtering.
pkg/cli/run_workflow_validation.go	Introduces readLockFile() and updates IsRunnable / getWorkflowInputs to use it.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

@copilot lint

Lint passed with 0 issues. All Go code is properly formatted and all JavaScript/JSON files pass Prettier checks.