Skip to content

Fix incorrect step count assertions in preflight diagnostic tests #20985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Mar 14, 2026
+14 −14
Merged

Fix incorrect step count assertions in preflight diagnostic tests #20985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7408f0
Initial plan
Copilot Mar 14, 2026
3cb3452
fix: correct test conditions for preflight step count checks
Copilot Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/workflow/copilot_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,7 @@ func TestCopilotPreflightDiagnosticStep(t *testing.T) {
steps := engine.GetExecutionSteps(workflowData, "/tmp/gh-aw/test.log")

// Should have only 1 step: execution (no preflight)
if len(steps) != 2 {
if len(steps) != 1 {
t.Fatalf("Expected 1 step (execution only), got %d", len(steps))
}

Expand All @@ -1701,7 +1701,7 @@ func TestCopilotPreflightDiagnosticStep(t *testing.T) {
steps := engine.GetExecutionSteps(workflowData, "/tmp/gh-aw/test.log")

// Should have only 1 step: execution (no preflight)
if len(steps) != 2 {
if len(steps) != 1 {
t.Fatalf("Expected 1 step (execution only), got %d", len(steps))
}

Expand Down
24 changes: 12 additions & 12 deletions pkg/workflow/engine_agent_import_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ func TestClaudeEngineWithAgentFromImports(t *testing.T) {

steps := engine.GetExecutionSteps(workflowData, "/tmp/gh-aw/test.log")

if len(steps) != 2 {
t.Fatalf("Expected 2 execution steps (preflight + execution), got %d", len(steps))
if len(steps) != 1 {
t.Fatalf("Expected 1 execution step, got %d", len(steps))
}

stepContent := strings.Join([]string(steps[1]), "\n")
stepContent := strings.Join([]string(steps[0]), "\n")

// Check that custom agent content extraction is present
if !strings.Contains(stepContent, `AGENT_CONTENT="$(awk`) {
Expand Down Expand Up @@ -160,11 +160,11 @@ func TestClaudeEngineWithoutAgentFile(t *testing.T) {

steps := engine.GetExecutionSteps(workflowData, "/tmp/gh-aw/test.log")

if len(steps) != 2 {
t.Fatalf("Expected 2 execution steps (preflight + execution), got %d", len(steps))
if len(steps) != 1 {
t.Fatalf("Expected 1 execution step, got %d", len(steps))
}

stepContent := strings.Join([]string(steps[1]), "\n")
stepContent := strings.Join([]string(steps[0]), "\n")

// Should not have agent content extraction
if strings.Contains(stepContent, "AGENT_CONTENT") {
Expand All @@ -190,11 +190,11 @@ func TestCodexEngineWithAgentFromImports(t *testing.T) {

steps := engine.GetExecutionSteps(workflowData, "/tmp/gh-aw/test.log")

if len(steps) != 2 {
t.Fatalf("Expected 2 execution steps (preflight + execution), got %d", len(steps))
if len(steps) != 1 {
t.Fatalf("Expected 1 execution step, got %d", len(steps))
}

stepContent := strings.Join([]string(steps[1]), "\n")
stepContent := strings.Join([]string(steps[0]), "\n")

// Check that agent content extraction is present
if !strings.Contains(stepContent, `AGENT_CONTENT="$(awk`) {
Expand Down Expand Up @@ -228,11 +228,11 @@ func TestCodexEngineWithoutAgentFile(t *testing.T) {

steps := engine.GetExecutionSteps(workflowData, "/tmp/gh-aw/test.log")

if len(steps) != 2 {
t.Fatalf("Expected 2 execution steps (preflight + execution), got %d", len(steps))
if len(steps) != 1 {
t.Fatalf("Expected 1 execution step, got %d", len(steps))
}

stepContent := strings.Join([]string(steps[1]), "\n")
stepContent := strings.Join([]string(steps[0]), "\n")

// Should not have agent content extraction
if strings.Contains(stepContent, "AGENT_CONTENT") {
Expand Down
Loading