[code-simplifier] refactor: simplify fastParseTitle state machine and deduplicate formatCompilerError

[github-actions]

This PR simplifies two pieces of code from PRs merged in the last 24 hours, improving clarity while preserving identical functionality.

Files Simplified

• pkg/cli/workflows.go — simplified fastParseTitle state machine
• pkg/workflow/compiler_error_formatter.go — eliminated duplicated struct construction

Improvements Made

1. fastParseTitle — removed redundant pastFrontmatter variable

The function tracked three booleans (firstLine, inFrontmatter, pastFrontmatter), but pastFrontmatter is redundant: once inFrontmatter becomes false after the opening ---, the code is already past any frontmatter. Removing it:

• Reduces state from 3 variables → 2
• Eliminates the pastFrontmatter && guard on the H1 check (implicit from !inFrontmatter)
• Simplifies the else if inFrontmatter && !pastFrontmatter branch to else if inFrontmatter
• Simplifies the post-loop check from inFrontmatter && !pastFrontmatter → inFrontmatter

2. formatCompilerError — deduplicated via wrapper

formatCompilerError and formatCompilerErrorWithPosition shared identical logic (same console.FormatError struct, same wrappedCompilerError return). formatCompilerError is now a thin wrapper that calls formatCompilerErrorWithPosition(filePath, 1, 1, ...), removing ~15 lines of duplicated code.

Changes Based On

Recent changes from:

• perf: optimize extractWorkflowNameFromFile by eliminating unnecessary YAML parse #21012 — perf: optimize extractWorkflowNameFromFile by eliminating unnecessary YAML parse (introduced fastParseTitle)
• Fix engine validation error location and improve error detection (#issue) #21023 — Fix engine validation error location and improve error detection (introduced formatCompilerErrorWithPosition, refactored formatCompilerError)

Testing

• ✅ All 10 TestFastParseTitle subtests pass
• ✅ All TestIsFormattedCompilerError, TestFindFrontmatterFieldLine, TestEngineValidationErrorHasFileLocation tests pass
• ✅ Build succeeds (make build)
• ✅ gofmt clean
• ✅ No functional changes — behavior is identical

Review Focus

Please verify:

• The fastParseTitle state transitions are equivalent to the original
• formatCompilerError delegation preserves the same log output (now shows line=1, column=1 in the log, same information)

---

Automated by Code Simplifier Agent — analyzing code from the last 24 hours

References: §23110390758

Generated by Code Simplifier · ◷

• expires on Mar 16, 2026, 12:38 PM UTC

[Copilot]

Pull request overview

This PR refactors two recently added helpers to reduce state/duplication while preserving behavior: fastParseTitle is simplified by removing redundant state, and formatCompilerError is simplified by delegating to formatCompilerErrorWithPosition.

Changes:

• Simplified fastParseTitle by removing pastFrontmatter and directly toggling inFrontmatter on close delimiter.
• Deduplicated compiler error formatting by making formatCompilerError a thin wrapper over formatCompilerErrorWithPosition(filePath, 1, 1, ...).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/cli/workflows.go	Simplifies frontmatter/title scanning state machine while keeping frontmatter semantics and error behavior intact.
pkg/workflow/compiler_error_formatter.go	Removes duplicated error-formatting struct construction by delegating to the positioned formatter.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.