Skip to content

[jsweep] Clean add_reaction.cjs #21160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Mar 16, 2026
Merged

[jsweep] Clean add_reaction.cjs #21160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 18 additions & 23 deletions actions/setup/js/add_reaction.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@
const { getErrorMessage, isLockedError } = require("./error_helpers.cjs");
const { ERR_API, ERR_NOT_FOUND, ERR_VALIDATION } = require("./error_codes.cjs");

/** Maps REST reaction names to GraphQL ReactionContent enum values */
const REACTION_MAP = {
"+1": "THUMBS_UP",
"-1": "THUMBS_DOWN",
laugh: "LAUGH",
confused: "CONFUSED",
heart: "HEART",
hooray: "HOORAY",
rocket: "ROCKET",
eyes: "EYES",
};

/**
* Add a reaction to the triggering item (issue, PR, comment, or discussion).
* This provides immediate feedback to the user when a workflow is triggered.
Expand All @@ -17,7 +29,7 @@ async function main() {
core.info(`Adding reaction: ${reaction}`);

// Validate reaction type
const validReactions = ["+1", "-1", "laugh", "confused", "heart", "hooray", "rocket", "eyes"];
const validReactions = Object.keys(REACTION_MAP);
if (!validReactions.includes(reaction)) {
core.setFailed(`${ERR_VALIDATION}: Invalid reaction type: ${reaction}. Valid reactions are: ${validReactions.join(", ")}`);
return;
Expand Down Expand Up @@ -101,7 +113,7 @@ async function main() {

// Add reaction using REST API (for non-discussion events)
core.info(`Adding reaction to: ${reactionEndpoint}`);
await addReaction(reactionEndpoint, reaction);
await addReaction(/** @type {string} */ reactionEndpoint, reaction);
} catch (error) {
const errorMessage = getErrorMessage(error);

Expand All @@ -124,21 +136,16 @@ async function main() {
* @param {string} reaction - The reaction type to add
*/
async function addReaction(endpoint, reaction) {
const response = await github.request("POST " + endpoint, {
const response = await github.request(`POST ${endpoint}`, {
content: reaction,
headers: {
Accept: "application/vnd.github+json",
},
});

const reactionId = response.data?.id;
if (reactionId) {
core.info(`Successfully added reaction: ${reaction} (id: ${reactionId})`);
core.setOutput("reaction-id", reactionId.toString());
} else {
core.info(`Successfully added reaction: ${reaction}`);
core.setOutput("reaction-id", "");
}
core.info(`Successfully added reaction: ${reaction}${reactionId ? ` (id: ${reactionId})` : ""}`);
core.setOutput("reaction-id", reactionId?.toString() ?? "");
}

/**
Expand All @@ -147,19 +154,7 @@ async function addReaction(endpoint, reaction) {
* @param {string} reaction - The reaction type to add (mapped to GitHub's ReactionContent enum)
*/
async function addDiscussionReaction(subjectId, reaction) {
// Map reaction names to GitHub's GraphQL ReactionContent enum
const reactionMap = {
"+1": "THUMBS_UP",
"-1": "THUMBS_DOWN",
laugh: "LAUGH",
confused: "CONFUSED",
heart: "HEART",
hooray: "HOORAY",
rocket: "ROCKET",
eyes: "EYES",
};

const reactionContent = reactionMap[reaction];
const reactionContent = REACTION_MAP[reaction];
if (!reactionContent) {
throw new Error(`${ERR_VALIDATION}: Invalid reaction type for GraphQL: ${reaction}`);
}
Expand Down
Loading