Skip to content

fix: update golden files for gh-aw-firewall v0.24.2 bump#21174

Merged
lpcox merged 2 commits intocopilot/bump-gh-aw-firewall-versionfrom
copilot/gt-67177116927-fix-github-actions-workflow
Mar 16, 2026
Merged

fix: update golden files for gh-aw-firewall v0.24.2 bump#21174
lpcox merged 2 commits intocopilot/bump-gh-aw-firewall-versionfrom
copilot/gt-67177116927-fix-github-actions-workflow

Conversation

Copy link
Contributor

Copilot AI commented Mar 16, 2026

TestWasmGolden_CompileFixtures was failing because the firewall version bump (0.24.10.24.2) wasn't reflected in the golden test snapshots.

Changes

  • Updated all v0.24.1 references to v0.24.2 in three golden files under pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/:
    • GH_AW_INFO_AWF_VERSION
    • install_awf_binary.sh argument
    • download_docker_images.sh image tags (agent, api-proxy, squid)
    • --image-tag argument to awf
Original prompt

Fix the failing GitHub Actions workflow test
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 67177116927
Job URL: https://github.com/github/gh-aw/actions/runs/23128598265/job/67177116927


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
@lpcox lpcox marked this pull request as ready for review March 16, 2026 05:07
Copilot AI review requested due to automatic review settings March 16, 2026 05:07
@lpcox lpcox merged commit 60163c3 into copilot/bump-gh-aw-firewall-version Mar 16, 2026
Copilot AI changed the title [WIP] [67177116927] Fix the failing GitHub Actions workflow test fix: update golden files for gh-aw-firewall v0.24.2 bump Mar 16, 2026
@lpcox lpcox deleted the copilot/gt-67177116927-fix-github-actions-workflow branch March 16, 2026 05:07
Copilot AI requested a review from lpcox March 16, 2026 05:07
Copilot stopped work on behalf of lpcox due to an error March 16, 2026 05:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates wasm golden test fixtures to align with the bumped AWF/firewall image tag version so TestWasmGolden_CompileFixtures passes in CI.

Changes:

  • Bump GH_AW_INFO_AWF_VERSION in golden outputs from v0.24.1 to v0.24.2.
  • Update AWF install and firewall container image references in golden outputs from 0.24.1 to 0.24.2.
  • Update awf --image-tag in golden outputs from 0.24.1 to 0.24.2.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden Updates AWF version and firewall image-tag references to 0.24.2 in compiled workflow golden.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden Updates AWF version and firewall image-tag references to 0.24.2 in smoke workflow golden.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden Updates AWF version and firewall image-tag references to 0.24.2 in basic workflow golden.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

lpcox added a commit that referenced this pull request Mar 16, 2026
* Initial plan

* chore: bump gh-aw-firewall default version to v0.24.2

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* [WIP] [67177116927] Fix the failing GitHub Actions workflow test (#21174)

* Initial plan

* fix: update golden files to use gh-aw-firewall v0.24.2

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants