Store default GitHub lockdown value as a named constant#21303
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update compiler to set default github lockdown to false
Store default GitHub lockdown value as a named constant
Mar 16, 2026
pelikhan
approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Extracts the hardcoded false default for GitHub MCP server lockdown mode into a named constant.
Changes:
- Added
DefaultGitHubLockdownconstant and updatedgetGitHubLockdownto use it
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/constants/constants.go | Added DefaultGitHubLockdown = false constant |
| pkg/workflow/mcp_github_config.go | Updated getGitHubLockdown to return the new constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
falsevalue for GitHub MCP server lockdown mode was hardcoded as a literal ingetGitHubLockdown()rather than expressed as a named constant.Changes
pkg/constants/constants.go: AddedDefaultGitHubLockdown = falseconstant alongside otherDefaultGitHub*constantspkg/workflow/mcp_github_config.go: UpdatedgetGitHubLockdownto returnconstants.DefaultGitHubLockdowninstead of a barefalseOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.