Skip to content

fix: remove leading empty comment line from generated lock.yml files#21413

Merged
pelikhan merged 1 commit intomainfrom
copilot/fix-empty-comment-line
Mar 17, 2026
Merged

fix: remove leading empty comment line from generated lock.yml files#21413
pelikhan merged 1 commit intomainfrom
copilot/fix-empty-comment-line

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

Every generated .lock.yml file started with a bare # line before the ASCII logo, producing unnecessary visual noise.

Changes

  • pkg/workflow/header.go — Remove the header.WriteString("#\n") written unconditionally before the logo lines in GenerateWorkflowHeader()
  • pkg/workflow/lock_schema_test.go — Drop the leading # from the hardcoded lock file fixture in TestExtractMetadataRealisticLockFile
  • 173 .lock.yml files — Recompiled; two fixtures (test-yaml-import.lock.yml, example-blocked-domains.lock.yml) patched manually

Before:

#
#    ___                   _   _
#   / _ \                 | | (_)

After:

#    ___                   _   _
#   / _ \                 | | (_)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review March 17, 2026 15:54
Copilot AI review requested due to automatic review settings March 17, 2026 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the leading empty # line from generated .lock.yml headers to reduce visual noise before the ASCII logo.

Changes:

  • Update header generation to stop emitting an unconditional blank comment line.
  • Update Go test fixture to match the new header format.
  • Regenerate lock/workflow YAML files to remove the initial standalone #.

Reviewed changes

Copilot reviewed 178 out of 178 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/workflow/header.go Stop writing a standalone # line before the ASCII logo header.
pkg/workflow/lock_schema_test.go Update the realistic lock-file fixture to no longer start with a blank # line.
pkg/workflow/test-yaml-import.lock.yml Regenerated header: remove leading bare #.
pkg/cli/workflows/example-blocked-domains.lock.yml Regenerated header, plus additional workflow content changes (versions/config) beyond header cleanup.
.github/workflows/workflow-skill-extractor.lock.yml Regenerated header: remove leading bare #.
.github/workflows/workflow-normalizer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/workflow-health-manager.lock.yml Regenerated header: remove leading bare #.
.github/workflows/workflow-generator.lock.yml Regenerated header: remove leading bare #.
.github/workflows/weekly-safe-outputs-spec-review.lock.yml Regenerated header: remove leading bare #.
.github/workflows/weekly-issue-summary.lock.yml Regenerated header: remove leading bare #.
.github/workflows/weekly-editors-health-check.lock.yml Regenerated header: remove leading bare #.
.github/workflows/video-analyzer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/update-astro.lock.yml Regenerated header: remove leading bare #.
.github/workflows/unbloat-docs.lock.yml Regenerated header: remove leading bare #.
.github/workflows/ubuntu-image-analyzer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/typist.lock.yml Regenerated header: remove leading bare #.
.github/workflows/tidy.lock.yml Regenerated header: remove leading bare #.
.github/workflows/test-workflow.lock.yml Regenerated header: remove leading bare #.
.github/workflows/test-project-url-default.lock.yml Regenerated header: remove leading bare #.
.github/workflows/test-dispatcher.lock.yml Regenerated header: remove leading bare #.
.github/workflows/test-create-pr-error-handling.lock.yml Regenerated header: remove leading bare #.
.github/workflows/terminal-stylist.lock.yml Regenerated header: remove leading bare #.
.github/workflows/technical-doc-writer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/super-linter.lock.yml Regenerated header: remove leading bare #.
.github/workflows/sub-issue-closer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/step-name-alignment.lock.yml Regenerated header: remove leading bare #.
.github/workflows/static-analysis-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/stale-repo-identifier.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-workflow-call.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-workflow-call-with-inputs.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-update-cross-repo-pr.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-test-tools.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-temporary-id.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-project.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-multi-pr.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-gemini.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-create-cross-repo-pr.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-copilot.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-copilot-arm.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-codex.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-claude.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-call-workflow.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-agent-scoped-approved.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-agent-public-none.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-agent-public-approved.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-agent-all-none.lock.yml Regenerated header: remove leading bare #.
.github/workflows/smoke-agent-all-merged.lock.yml Regenerated header: remove leading bare #.
.github/workflows/slide-deck-maintainer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/sergo.lock.yml Regenerated header: remove leading bare #.
.github/workflows/semantic-function-refactor.lock.yml Regenerated header: remove leading bare #.
.github/workflows/security-review.lock.yml Regenerated header: remove leading bare #.
.github/workflows/security-compliance.lock.yml Regenerated header: remove leading bare #.
.github/workflows/security-alert-burndown.campaign.g.lock.yml Regenerated header: remove leading bare #.
.github/workflows/scout.lock.yml Regenerated header: remove leading bare #.
.github/workflows/schema-consistency-checker.lock.yml Regenerated header: remove leading bare #.
.github/workflows/safe-output-health.lock.yml Regenerated header: remove leading bare #.
.github/workflows/research.lock.yml Regenerated header: remove leading bare #.
.github/workflows/repository-quality-improver.lock.yml Regenerated header: remove leading bare #.
.github/workflows/repo-tree-map.lock.yml Regenerated header: remove leading bare #.
.github/workflows/repo-audit-analyzer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/release.lock.yml Regenerated header: remove leading bare #.
.github/workflows/refiner.lock.yml Regenerated header: remove leading bare #.
.github/workflows/q.lock.yml Regenerated header: remove leading bare #.
.github/workflows/python-data-charts.lock.yml Regenerated header: remove leading bare #.
.github/workflows/prompt-clustering-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/pr-triage-agent.lock.yml Regenerated header: remove leading bare #.
.github/workflows/pr-nitpick-reviewer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/portfolio-analyst.lock.yml Regenerated header: remove leading bare #.
.github/workflows/poem-bot.lock.yml Regenerated header: remove leading bare #.
.github/workflows/plan.lock.yml Regenerated header: remove leading bare #.
.github/workflows/pdf-summary.lock.yml Regenerated header: remove leading bare #.
.github/workflows/org-health-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/notion-issue-summary.lock.yml Regenerated header: remove leading bare #.
.github/workflows/metrics-collector.lock.yml Regenerated header: remove leading bare #.
.github/workflows/mergefest.lock.yml Regenerated header: remove leading bare #.
.github/workflows/mcp-inspector.lock.yml Regenerated header: remove leading bare #.
.github/workflows/lockfile-stats.lock.yml Regenerated header: remove leading bare #.
.github/workflows/layout-spec-maintainer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/jsweep.lock.yml Regenerated header: remove leading bare #.
.github/workflows/issue-triage-agent.lock.yml Regenerated header: remove leading bare #.
.github/workflows/issue-monster.lock.yml Regenerated header: remove leading bare #.
.github/workflows/issue-arborist.lock.yml Regenerated header: remove leading bare #.
.github/workflows/instructions-janitor.lock.yml Regenerated header: remove leading bare #.
.github/workflows/hourly-ci-cleaner.lock.yml Regenerated header: remove leading bare #.
.github/workflows/grumpy-reviewer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/gpclean.lock.yml Regenerated header: remove leading bare #.
.github/workflows/go-pattern-detector.lock.yml Regenerated header: remove leading bare #.
.github/workflows/go-logger.lock.yml Regenerated header: remove leading bare #.
.github/workflows/go-fan.lock.yml Regenerated header: remove leading bare #.
.github/workflows/glossary-maintainer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/github-remote-mcp-auth-test.lock.yml Regenerated header: remove leading bare #.
.github/workflows/github-mcp-tools-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/github-mcp-structural-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/functional-pragmatist.lock.yml Regenerated header: remove leading bare #.
.github/workflows/firewall.lock.yml Regenerated header: remove leading bare #.
.github/workflows/firewall-escape.lock.yml Regenerated header: remove leading bare #.
.github/workflows/example-workflow-analyzer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/example-permissions-warning.lock.yml Regenerated header: remove leading bare #.
.github/workflows/duplicate-code-detector.lock.yml Regenerated header: remove leading bare #.
.github/workflows/draft-pr-cleanup.lock.yml Regenerated header: remove leading bare #.
.github/workflows/docs-noob-tester.lock.yml Regenerated header: remove leading bare #.
.github/workflows/discussion-task-miner.lock.yml Regenerated header: remove leading bare #.
.github/workflows/dictation-prompt.lock.yml Regenerated header: remove leading bare #.
.github/workflows/developer-docs-consolidator.lock.yml Regenerated header: remove leading bare #.
.github/workflows/dev.lock.yml Regenerated header: remove leading bare #.
.github/workflows/dev-hawk.lock.yml Regenerated header: remove leading bare #.
.github/workflows/dependabot-go-checker.lock.yml Regenerated header: remove leading bare #.
.github/workflows/dependabot-burner.lock.yml Regenerated header: remove leading bare #.
.github/workflows/delight.lock.yml Regenerated header: remove leading bare #.
.github/workflows/deep-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/dead-code-remover.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-workflow-updater.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-testify-uber-super-expert.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-team-status.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-team-evolution-insights.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-syntax-error-quality.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-semgrep-scan.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-security-red-team.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-secrets-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-safe-outputs-conformance.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-safe-output-optimizer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-repo-chronicle.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-rendering-scripts-verifier.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-regulatory.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-performance-summary.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-observability-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-news.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-multi-device-docs-tester.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-mcp-concurrency-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-malicious-code-scan.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-issues-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-function-namer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-firewall-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-file-diet.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-fact.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-doc-updater.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-doc-healer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-copilot-token-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-compiler-quality.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-code-metrics.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-cli-tools-tester.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-cli-performance.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-choice-test.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-assign-issue-to-user.lock.yml Regenerated header: remove leading bare #.
.github/workflows/daily-architecture-diagram.lock.yml Regenerated header: remove leading bare #.
.github/workflows/craft.lock.yml Regenerated header: remove leading bare #.
.github/workflows/copilot-session-insights.lock.yml Regenerated header: remove leading bare #.
.github/workflows/copilot-pr-prompt-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/copilot-pr-nlp-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/copilot-pr-merged-report.lock.yml Regenerated header: remove leading bare #.
.github/workflows/copilot-cli-deep-research.lock.yml Regenerated header: remove leading bare #.
.github/workflows/copilot-agent-analysis.lock.yml Regenerated header: remove leading bare #.
.github/workflows/contribution-check.lock.yml Regenerated header: remove leading bare #.
.github/workflows/constraint-solving-potd.lock.yml Regenerated header: remove leading bare #.
.github/workflows/commit-changes-analyzer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/codex-github-remote-mcp-test.lock.yml Regenerated header: remove leading bare #.
.github/workflows/code-simplifier.lock.yml Regenerated header: remove leading bare #.
.github/workflows/code-scanning-fixer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/cloclo.lock.yml Regenerated header: remove leading bare #.
.github/workflows/cli-version-checker.lock.yml Regenerated header: remove leading bare #.
.github/workflows/cli-consistency-checker.lock.yml Regenerated header: remove leading bare #.
.github/workflows/claude-code-user-docs-review.lock.yml Regenerated header: remove leading bare #.
.github/workflows/ci-doctor.lock.yml Regenerated header: remove leading bare #.
.github/workflows/ci-coach.lock.yml Regenerated header: remove leading bare #.
.github/workflows/changeset.lock.yml Regenerated header: remove leading bare #.
.github/workflows/breaking-change-checker.lock.yml Regenerated header: remove leading bare #.
.github/workflows/brave.lock.yml Regenerated header: remove leading bare #.
.github/workflows/bot-detection.lock.yml Regenerated header: remove leading bare #.
.github/workflows/blog-auditor.lock.yml Regenerated header: remove leading bare #.
.github/workflows/auto-triage-issues.lock.yml Regenerated header: remove leading bare #.
.github/workflows/audit-workflows.lock.yml Regenerated header: remove leading bare #.
.github/workflows/artifacts-summary.lock.yml Regenerated header: remove leading bare #.
.github/workflows/archie.lock.yml Regenerated header: remove leading bare #.
.github/workflows/ai-moderator.lock.yml Regenerated header: remove leading bare #.
.github/workflows/agentics-maintenance.yml Header cleanup applied to a non-.lock.yml workflow file.
.github/workflows/agent-persona-explorer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/agent-performance-analyzer.lock.yml Regenerated header: remove leading bare #.
.github/workflows/ace-editor.lock.yml Regenerated header: remove leading bare #.
Comments suppressed due to low confidence (8)

pkg/cli/workflows/example-blocked-domains.lock.yml:1

  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.
    pkg/cli/workflows/example-blocked-domains.lock.yml:1
  • This file includes substantial functional changes beyond removing the leading blank # header line (e.g., checkout repository, AWF version bumps, new guard policy wiring, continue-on-error). That doesn’t match the PR’s stated scope and makes review/risk assessment harder. Suggestion (mandatory): split these workflow behavior/version updates into a separate PR, or revert them here and keep this PR limited to header regeneration; alternatively, update the PR description/title to explicitly call out these behavior changes and why they are expected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 1 to 3
# ___ _ _
# / _ \ | | (_)
# | |_| | __ _ ___ _ __ | |_ _ ___
@pelikhan pelikhan merged commit ae39867 into main Mar 17, 2026
93 checks passed
@pelikhan pelikhan deleted the copilot/fix-empty-comment-line branch March 17, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants