refactor: extract shared renderStandardJSONMCPConfig helper across engine MCP modules

pkg/workflow/claude_mcp.go

@@ -13,17 +13,11 @@ func (e *ClaudeEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]a
 	claudeMCPLog.Printf("Rendering MCP config for Claude: tool_count=%d, mcp_tool_count=%d", len(tools), len(mcpTools))
 
 	// Claude uses JSON format without Copilot-specific fields and multi-line args
-	createRenderer := buildMCPRendererFactory(workflowData, "json", false, false)
-
-	// Build gateway configuration for MCP config
-	// Per MCP Gateway Specification v1.0.0 section 4.1.3, the gateway section is required
-	return RenderJSONMCPConfig(yaml, tools, mcpTools, workflowData, JSONMCPConfigOptions{
-		ConfigPath:    "/tmp/gh-aw/mcp-config/mcp-servers.json",
-		GatewayConfig: buildMCPGatewayConfig(workflowData),
-		Renderers: buildStandardJSONMCPRenderers(workflowData, createRenderer, false, func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
+	return renderStandardJSONMCPConfig(yaml, tools, mcpTools, workflowData,
+		"/tmp/gh-aw/mcp-config/mcp-servers.json", false, false, false,
+		func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
 			return e.renderClaudeMCPConfigWithContext(yaml, toolName, toolConfig, isLast, workflowData)
-		}),
-	})
+		}, nil)
 }
 
 // renderClaudeMCPConfigWithContext generates custom MCP server configuration for a single tool in Claude workflow mcp-servers.json

pkg/workflow/codex_mcp.go

@@ -103,20 +103,12 @@ func (e *CodexEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]an
 	yaml.WriteString("          \n")
 	yaml.WriteString("          # Generate JSON config for MCP gateway\n")
 
-	// Build gateway configuration
-	gatewayConfig := buildMCPGatewayConfig(workflowData)
-
-	// Use shared JSON renderer for gateway input
 	// Gateway uses JSON format without Copilot-specific fields and multi-line args
-	createJSONRenderer := buildMCPRendererFactory(workflowData, "json", false, false)
-
-	return RenderJSONMCPConfig(yaml, tools, mcpTools, workflowData, JSONMCPConfigOptions{
-		ConfigPath:    "/tmp/gh-aw/mcp-config/mcp-servers.json",
-		GatewayConfig: gatewayConfig,
-		Renderers: buildStandardJSONMCPRenderers(workflowData, createJSONRenderer, false, func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
+	return renderStandardJSONMCPConfig(yaml, tools, mcpTools, workflowData,
+		"/tmp/gh-aw/mcp-config/mcp-servers.json", false, false, false,
+		func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
 			return e.renderCodexJSONMCPConfigWithContext(yaml, toolName, toolConfig, isLast, workflowData)
-		}),
-	})
+		}, nil)
 }
 
 // renderCodexMCPConfigWithContext generates custom MCP server configuration for a single tool in codex workflow config.toml

pkg/workflow/copilot_mcp.go

@@ -8,6 +8,12 @@ import (
 
 var copilotMCPLog = logger.New("workflow:copilot_mcp")
 
+// copilotMCPToolFilter returns true for MCP tools that should be included in the Copilot MCP config.
+// Cache-memory is excluded because it is handled as a simple file share, not an MCP server.
+func copilotMCPToolFilter(toolName string) bool {
+	return toolName != "cache-memory"
+}
+
 // RenderMCPConfig generates MCP server configuration for Copilot CLI
 func (e *CopilotEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]any, mcpTools []string, workflowData *WorkflowData) error {
 	copilotMCPLog.Printf("Rendering MCP config for Copilot engine: mcpTools=%d", len(mcpTools))
@@ -16,25 +22,14 @@ func (e *CopilotEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]
 	yaml.WriteString("          mkdir -p /home/runner/.copilot\n")
 
 	// Copilot uses JSON format with type and tools fields, and inline args
-	createRenderer := buildMCPRendererFactory(workflowData, "json", true, true)
-
-	// Build gateway configuration for MCP config
-	// Per MCP Gateway Specification v1.0.0 section 4.1.3, the gateway section is required
-	options := JSONMCPConfigOptions{
-		ConfigPath:    "/home/runner/.copilot/mcp-config.json",
-		GatewayConfig: buildMCPGatewayConfig(workflowData),
-		// webFetchIncludeTools=true: Copilot requires a tools field in the web-fetch server config
-		Renderers: buildStandardJSONMCPRenderers(workflowData, createRenderer, true, func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
+	// webFetchIncludeTools=true: Copilot requires a tools field in the web-fetch server config
+	return renderStandardJSONMCPConfig(yaml, tools, mcpTools, workflowData,
+		"/home/runner/.copilot/mcp-config.json", true, true, true,
+		func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
 			return e.renderCopilotMCPConfigWithContext(yaml, toolName, toolConfig, isLast, workflowData)
-		}),
-		FilterTool: func(toolName string) bool {
-			// Filter out cache-memory for Copilot
-			// Cache-memory is handled as a simple file share, not an MCP server
-			return toolName != "cache-memory"
 		},
-	}
-
-	return RenderJSONMCPConfig(yaml, tools, mcpTools, workflowData, options)
+		copilotMCPToolFilter,
+	)
 }
 
 // renderCopilotMCPConfigWithContext generates custom MCP server configuration for Copilot CLI

pkg/workflow/gemini_mcp.go

@@ -13,14 +13,9 @@ func (e *GeminiEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]a
 	geminiMCPLog.Printf("Rendering MCP config for Gemini: tool_count=%d, mcp_tool_count=%d", len(tools), len(mcpTools))
 
 	// Gemini uses JSON format without Copilot-specific fields and multi-line args
-	createRenderer := buildMCPRendererFactory(workflowData, "json", false, false)
-
-	// Use shared JSON MCP config renderer
-	return RenderJSONMCPConfig(yaml, tools, mcpTools, workflowData, JSONMCPConfigOptions{
-		ConfigPath:    "/tmp/gh-aw/mcp-config/mcp-servers.json",
-		GatewayConfig: buildMCPGatewayConfig(workflowData),
-		Renderers: buildStandardJSONMCPRenderers(workflowData, createRenderer, false, func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
+	return renderStandardJSONMCPConfig(yaml, tools, mcpTools, workflowData,
+		"/tmp/gh-aw/mcp-config/mcp-servers.json", false, false, false,
+		func(yaml *strings.Builder, toolName string, toolConfig map[string]any, isLast bool) error {
 			return renderCustomMCPConfigWrapperWithContext(yaml, toolName, toolConfig, isLast, workflowData)
-		}),
-	})
+		}, nil)
 }

pkg/workflow/mcp_renderer_helpers.go

@@ -2,6 +2,42 @@ package workflow
 
 import "strings"
 
+// renderStandardJSONMCPConfig is a shared helper for JSON MCP config rendering used by
+// Claude, Gemini, Copilot, and Codex engines. It consolidates the repeated sequence of:
+// buildMCPRendererFactory → buildMCPGatewayConfig → buildStandardJSONMCPRenderers → RenderJSONMCPConfig.
+//
+// Parameters:
+//   - yaml: output builder
+//   - tools: tool configurations from frontmatter
+//   - mcpTools: list of enabled MCP tool names
+//   - workflowData: compiled workflow context
+//   - configPath: engine-specific MCP config file path
+//   - includeCopilotFields: whether to include "type" and "tools" fields (true for Copilot)
+//   - inlineArgs: whether to render args inline (true for Copilot) vs multi-line
+//   - webFetchIncludeTools: whether the web-fetch server includes a tools field (true for Copilot)
+//   - renderCustom: engine-specific handler for custom MCP tool entries
+//   - filterTool: optional tool filter function; nil to include all tools
+func renderStandardJSONMCPConfig(
+	yaml *strings.Builder,
+	tools map[string]any,
+	mcpTools []string,
+	workflowData *WorkflowData,
+	configPath string,
+	includeCopilotFields bool,
+	inlineArgs bool,
+	webFetchIncludeTools bool,
+	renderCustom RenderCustomMCPToolConfigHandler,
+	filterTool func(string) bool,
+) error {
+	createRenderer := buildMCPRendererFactory(workflowData, "json", includeCopilotFields, inlineArgs)
+	return RenderJSONMCPConfig(yaml, tools, mcpTools, workflowData, JSONMCPConfigOptions{
+		ConfigPath:    configPath,
+		GatewayConfig: buildMCPGatewayConfig(workflowData),
+		Renderers:     buildStandardJSONMCPRenderers(workflowData, createRenderer, webFetchIncludeTools, renderCustom),
+		FilterTool:    filterTool,
+	})
+}
+
 // buildMCPRendererFactory creates a factory function for MCPConfigRendererUnified instances.
 // The returned function accepts isLast as a parameter and creates a renderer with engine-specific
 // options derived from the provided parameters and workflowData at call time.