docs: fix accessibility and build issues from multi-device testing report#21912
Closed
docs: fix accessibility and build issues from multi-device testing report#21912
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4ed9787e-a3ce-4b69-ae87-20059a739509
Copilot
AI
changed the title
[WIP] Update multi-device docs testing report for 2026-03-20
docs: fix accessibility and build issues from multi-device testing report
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes multiple accessibility and docs build issues found during multi-device automated testing, primarily by deduplicating document titles, improving accessible markup, and addressing Starlight plugin/component conflicts.
Changes:
- Deduplicates the homepage
<title>by filtering Starlight’s generated<title>and emitting a custom one. - Improves accessibility: decorative logo
alt=""and addsscopeattributes to table headers via the responsive table enhancer. - Resolves docs build warnings/conflicts: aliases
abnffences totexthighlighting and adjustsstarlight-blogtheme/nav integration.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/src/scripts/responsive-tables.ts | Adds scope="col"/scope="row" to table header cells for improved accessibility. |
| docs/src/content/docs/reference/fuzzy-schedule-specification.md | Removes explicit H1 to avoid duplicate H1 with Starlight-rendered title. |
| docs/src/content/docs/agent-factory-status.mdx | Adds two workflow entries to the status table. |
| docs/src/components/ThemeToggle.astro | Renders starlight-blog’s ThemeSelect component alongside the custom theme toggle. |
| docs/src/components/CustomLogo.astro | Makes the logo image decorative by setting empty alt text. |
| docs/src/components/CustomHead.astro | Filters Starlight <title> and emits a deduplicated page title while keeping OG/Twitter overrides. |
| docs/astro.config.mjs | Adds Shiki langAlias for abnf and disables blog navigation injection to avoid override conflicts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+34
| // Generate the correct page title (avoids "Site | Site" duplicate on homepage) | ||
| const pageTitle = isHomePage ? siteTitle : `${rawPageTitle} | ${siteTitle}`; | ||
|
|
There was a problem hiding this comment.
pageTitle duplicates the same conditional formatting already used for ogTitle. Consider deriving ogTitle (and the Twitter title) from pageTitle to keep the HTML <title> and OG/Twitter titles from drifting if the formatting logic changes later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six issues identified in the automated docs testing report: duplicate homepage
<title>, decorative logo with redundant alt text, missingscopeon table headers, duplicate H1 on the fuzzy-schedule spec page, unsupportedabnfcode fence language, and aThemeSelectcomponent conflict withstarlight-blog.Changes
Duplicate homepage title (
CustomHead.astro): Filter Starlight's generated<title>tag and emit our own, so the homepage renders"GitHub Agentic Workflows"instead of"GitHub Agentic Workflows | GitHub Agentic Workflows".Decorative logo alt text (
CustomLogo.astro): Changealt="GitHub Agentic Workflows"→alt="". The adjacent<span>in the same link already carries the accessible label.Table header
scope(responsive-tables.ts): Extend the existing client-side table enhancement to setscope="col"on<thead th>andscope="row"on<tbody th>across all pages.Duplicate H1 (
fuzzy-schedule-specification.md): Remove the explicit# Fuzzy Schedule Time Syntax Specificationheading — Starlight renders the frontmattertitleas the page H1 already.ABNF code fence (
astro.config.mjs): Addabnf: "text"to Shiki'slangAliasmap soabnfblocks get plain-text highlighting without a build warning.ThemeSelect/starlight-blogconflict (ThemeToggle.astro,astro.config.mjs): The blog plugin'sThemeSelectoverride (which injects a "Blog" header link) conflicted with our custom theme toggle. Fixed by renderingstarlight-blog/components/ThemeSelect.astroinsideThemeToggle.astroand settingnavigation: 'none'in the plugin config to suppress the duplicate-override build warning.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/opt/hostedtoolcache/node/24.14.0/x64/bin/node node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build(dns block)/opt/hostedtoolcache/node/24.14.0/x64/bin/node node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build es/index.html &&--log-level ache�� -o public/slides/index.html actory in/sh s/gh-aw-theme.css -o public/slides/index.html && mkdir -p public/slides && cp slides/github-age(dns block)/opt/hostedtoolcache/node/24.14.0/x64/bin/node node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build sh ache�� -o public/slides/index.html starlight-blog/libs/remark.ts starlight-blog/libs/config.ts s/gh-aw-theme.css -o public/slides/index.html && mkdir -p public/slides && cp slides/github-age starlight-blog/l-c starlight-blog/lnpm run generate-agent-factory && npm run build:slides starlight-blog/libs/path.ts star�� starlight-blog/libs/vite.ts starlight-blog/libs/authors.ts starlight-blog/libs/title.ts starlight-blog/lnode starlight-blog/l/opt/hostedtoolcache/node/24.14.0/x64/bin/npx starlight-blog/l@marp-team/marp-cli starlight-blog/lslides/index.md(dns block)If you need me to access, download, or install something from one of these locations, you can either:
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.