Skip to content

fix: smoke-gemini scheduled runs fail due to unconditional add_comment + recompile stale lock files #21920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Mar 20, 2026
Merged

fix: smoke-gemini scheduled runs fail due to unconditional add_comment + recompile stale lock files #21920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf9444f
Initial plan
Copilot Mar 20, 2026
c979910
chore: initial plan for workflow health fixes
Copilot Mar 20, 2026
a6ef708
fix: update smoke-gemini to conditionally use add_comment on PR event…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/smoke-gemini.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions .github/workflows/smoke-gemini.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,19 @@ timeout-minutes: 10

## Output

Add a **very brief** comment (max 5-10 lines) to the current pull request with:
**ALWAYS create an issue** with a summary of the smoke test run:
- Title: "Smoke Test: Gemini - ${{ github.run_id }}"
- Body should include:
- Test results (✅ or ❌ for each test)
- Overall status: PASS or FAIL
- Run URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
- Timestamp

**Only if this workflow was triggered by a pull_request event**: Use the `add_comment` tool to add a **very brief** comment (max 5-10 lines) to the triggering pull request (omit the `item_number` parameter to auto-target the triggering PR) with:
- ✅ or ❌ for each test result
- Overall status: PASS or FAIL

If all tests pass, use the `add_labels` safe-output tool to add the label `smoke-gemini` to the pull request.
If all tests pass and this workflow was triggered by a pull_request event, use the `add_labels` safe-output tool to add the label `smoke-gemini` to the pull request (omit the `item_number` parameter to auto-target the triggering PR).
Comment on lines +78 to +82
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions gate add_comment/add_labels on being triggered by a pull_request event, but the agent prompt doesn’t appear to expose github.event_name (only optional pull-request-number in the GitHub context). To avoid accidental safe-output failures on schedule/workflow_dispatch, consider keying the condition on whether a PR context is present (e.g., only run these steps if the GitHub context includes a pull request number).

See below for a potential fix:

**Only if a pull request context is available (e.g., the GitHub context includes a pull request number)**: Use the `add_comment` tool to add a **very brief** comment (max 5-10 lines) to the relevant pull request (omit the `item_number` parameter to auto-target the triggering PR) with:
- ✅ or ❌ for each test result
- Overall status: PASS or FAIL

If all tests pass and a pull request context is available (e.g., the GitHub context includes a pull request number), use the `add_labels` safe-output tool to add the label `smoke-gemini` to the pull request (omit the `item_number` parameter to auto-target the triggering PR).

Copilot uses AI. Check for mistakes.

**Important**: If no action is needed after completing your analysis, you **MUST** call the `noop` safe-output tool with a brief explanation. Failing to call any safe-output tool is the most common cause of safe-output workflow failures.

Expand Down
Loading