Remove "defaults" section from main JSON schema#2200
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Removed top-level "defaults" property definition (lines 1073-1094) - Removed "$ref" to defaults within jobs section (lines 1197-1199) - Removed "defaults" from PriorityJobFields constant in constants.go - Removed test cases that used the defaults field - All tests pass and workflows compile successfully Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove defaults section from main json schema
Remove "defaults" section from main JSON schema
Oct 23, 2025
pelikhan
approved these changes
Oct 23, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
defaultssection from the main workflow schema (main_workflow_schema.json). This section was intended for GitHub Actions workflow defaults (default shell and working directory) but was not being used in any workflows and added unnecessary complexity to the schema.Changes
Schema Updates:
defaultsproperty definition frommain_workflow_schema.json(lines 1073-1094)$refreference to defaults within the jobs section (lines 1197-1199)Code Updates:
defaultsfromPriorityJobFieldsconstant inpkg/constants/constants.gopkg/parser/schema_test.goDocumentation:
Validation
The schema now correctly rejects workflows that attempt to use the
defaultsfield:Important Note: The
defaultsnetwork access mode (e.g.,network: defaults) is a completely separate feature and remains unchanged. This PR only removes the GitHub Actions workflow defaults section that was not being utilized.Testing
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.