Skip to content

Replace hardcoded hex colors in progress.go with adaptive style constants#22099

Merged
pelikhan merged 2 commits intomainfrom
copilot/replace-hardcoded-lipgloss-colors
Mar 21, 2026
Merged

Replace hardcoded hex colors in progress.go with adaptive style constants#22099
pelikhan merged 2 commits intomainfrom
copilot/replace-hardcoded-lipgloss-colors

Conversation

Copy link
Contributor

Copilot AI commented Mar 21, 2026

The progress bar used hardcoded Dracula dark-palette hex colors that break the adaptive color contract — colors looked wrong on light-background terminals.

Changes

  • pkg/console/progress.go: Replace three hardcoded lipgloss.Color("#...") values with adaptive constants from pkg/styles/theme.go:
// Before
progress.WithColors(lipgloss.Color("#BD93F9"), lipgloss.Color("#8BE9FD"))
prog.EmptyColor = lipgloss.Color("#6272A4")

// After
progress.WithColors(styles.ColorPurple, styles.ColorInfo)
prog.EmptyColor = styles.ColorComment
  • Swap lipgloss import for styles package import (lipgloss no longer directly referenced)
  • Update inline comments to drop stale hex references

compat.AdaptiveColor satisfies image/color.Color, so the constants pass directly to progress.WithColors and EmptyColor without any wrapping.


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI changed the title [WIP] Replace hardcoded lipgloss colors with adaptive style constants Replace hardcoded hex colors in progress.go with adaptive style constants Mar 21, 2026
Copilot AI requested a review from pelikhan March 21, 2026 05:30
@pelikhan pelikhan marked this pull request as ready for review March 21, 2026 05:40
Copilot AI review requested due to automatic review settings March 21, 2026 05:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the console progress bar to use the shared adaptive theme colors instead of hardcoded Dracula hex values, improving appearance on light-background terminals.

Changes:

  • Replace hardcoded progress gradient and empty-bar colors with pkg/styles adaptive color constants.
  • Remove direct lipgloss usage from pkg/console/progress.go (switch import to styles).
  • Refresh inline comments to describe adaptive behavior rather than specific hex values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan pelikhan merged commit 4755583 into main Mar 21, 2026
115 checks passed
@pelikhan pelikhan deleted the copilot/replace-hardcoded-lipgloss-colors branch March 21, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plan] Replace hardcoded lipgloss colors in progress.go with adaptive style constants

3 participants