Replace hardcoded hex colors in progress.go with adaptive style constants#22099
Merged
Replace hardcoded hex colors in progress.go with adaptive style constants#22099
Conversation
6 tasks
…yle constants Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/34fbbd7e-41ea-400e-a8b0-2597aa6b3afe
Copilot
AI
changed the title
[WIP] Replace hardcoded lipgloss colors with adaptive style constants
Replace hardcoded hex colors in progress.go with adaptive style constants
Mar 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the console progress bar to use the shared adaptive theme colors instead of hardcoded Dracula hex values, improving appearance on light-background terminals.
Changes:
- Replace hardcoded progress gradient and empty-bar colors with
pkg/stylesadaptive color constants. - Remove direct
lipglossusage frompkg/console/progress.go(switch import tostyles). - Refresh inline comments to describe adaptive behavior rather than specific hex values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pelikhan
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress bar used hardcoded Dracula dark-palette hex colors that break the adaptive color contract — colors looked wrong on light-background terminals.
Changes
pkg/console/progress.go: Replace three hardcodedlipgloss.Color("#...")values with adaptive constants frompkg/styles/theme.go:lipglossimport forstylespackage import (lipgloss no longer directly referenced)compat.AdaptiveColorsatisfiesimage/color.Color, so the constants pass directly toprogress.WithColorsandEmptyColorwithout any wrapping.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.