Drain HTTP response bodies on non-OK paths to enable TCP connection reuse#22101
Merged
Drain HTTP response bodies on non-OK paths to enable TCP connection reuse#22101
Conversation
Closed
4 tasks
…tion reuse Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/649256a7-dc17-4d92-ad82-5e45595401eb
Copilot
AI
changed the title
[WIP] Add drain for HTTP response bodies on non-OK paths
Drain HTTP response bodies on non-OK paths to enable TCP connection reuse
Mar 21, 2026
Copilot stopped work on behalf of
pelikhan due to an error
March 21, 2026 05:35
pelikhan
approved these changes
Mar 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures HTTP response bodies are drained on non-200/OK paths so Go’s net/http transport can reuse TCP connections instead of discarding them.
Changes:
- Drain
resp.Bodywithio.Copy(io.Discard, resp.Body)before returning errors on non-OK HTTP responses in several call sites. - Applies this to raw GitHub content fetches and CLI dependency/security queries.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/parser/remote_fetch.go | Drain raw URL response body before returning an error on non-OK status. |
| pkg/cli/agent_download.go | Drain agent download response body on non-OK status (but currently misses an early-return path). |
| pkg/cli/deps_outdated.go | Drain Go proxy response body before returning an error on non-OK status. |
| pkg/cli/deps_security.go | Drain GitHub Advisory API response body before returning an error on non-OK status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
55
to
71
| if resp.StatusCode != http.StatusOK { | ||
| // Fall back to gh CLI for authenticated access (e.g., private repos in codespaces) | ||
| if resp.StatusCode == http.StatusNotFound && isGHCLIAvailable() { | ||
| agentDownloadLog.Print("Unauthenticated download returned 404, trying gh CLI for authenticated access") | ||
| if verbose { | ||
| fmt.Fprintln(os.Stderr, console.FormatInfoMessage("Retrying download with gh CLI authentication...")) | ||
| } | ||
| if content, ghErr := downloadAgentFileViaGHCLI(ref); ghErr == nil { | ||
| patchedContent := patchAgentFileURLs(content, ref) | ||
| agentDownloadLog.Printf("Successfully downloaded agent file via gh CLI (%d bytes)", len(patchedContent)) | ||
| return patchedContent, nil | ||
| } else { | ||
| agentDownloadLog.Printf("gh CLI fallback failed: %v", ghErr) | ||
| } | ||
| } | ||
| _, _ = io.Copy(io.Discard, resp.Body) | ||
| return "", fmt.Errorf("failed to download agent file: HTTP %d", resp.StatusCode) |
There was a problem hiding this comment.
In this non-OK branch, the response body is only drained right before the final error return. If the 404 + gh CLI fallback succeeds, the function returns early (line 65) and never executes the drain, so the original HTTP connection still won't be eligible for reuse. Consider draining (and optionally closing) the raw HTTP response body immediately after detecting resp.StatusCode != http.StatusOK, before any early returns in the fallback path.
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_, _ = io.Copy(io.Discard, resp.Body)before non-OK return inpkg/parser/remote_fetch.go_, _ = io.Copy(io.Discard, resp.Body)before non-OK return inpkg/cli/agent_download.go_, _ = io.Copy(io.Discard, resp.Body)before non-OK return inpkg/cli/deps_outdated.go_, _ = io.Copy(io.Discard, resp.Body)before non-OK return inpkg/cli/deps_security.gomake fmtpasses, code compiles cleanly💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.