fix: update integrity filter blocked message and bold summary headers#22173
fix: update integrity filter blocked message and bold summary headers#22173
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6741fb4e-31c9-451c-af8d-3301d527d8e3
|
@copilot always make details summary bold |
…blocked sections Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/430547cc-7977-463f-b7ff-a7e718b43a1d
There was a problem hiding this comment.
Pull request overview
Updates copy/styling for integrity-filter and firewall “blocked” step-summary sections, plus aligns associated tests and remediation text.
Changes:
- Adjusts integrity-filter blocked message text and removes the trailing “See Integrity Filtering…” sentence from remediation markdown.
- Makes
<summary>headers bold for integrity-filter and firewall blocked sections. - Updates unit tests to assert the new message text and summary formatting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/md/integrity_filter_remediation.md | Removes trailing documentation sentence from remediation snippet. |
| actions/setup/js/gateway_difc_filtered.cjs | Updates integrity blocked message text; attempts to bold the <summary> label. |
| actions/setup/js/gateway_difc_filtered.test.cjs | Updates assertions for new integrity message and summary formatting. |
| actions/setup/js/firewall_blocked_domains.cjs | Attempts to bold the <summary> label in the firewall blocked section. |
| actions/setup/js/firewall_blocked_domains.test.cjs | Updates assertions for the new firewall summary formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let section = "\n\n> [!NOTE]\n"; | ||
| section += `> <details>\n`; | ||
| section += `> <summary>🔒 Integrity filter blocked ${count} ${itemWord}</summary>\n`; | ||
| section += `> <summary>**🔒 Integrity filter blocked ${count} ${itemWord}**</summary>\n`; |
There was a problem hiding this comment.
<summary> is an HTML tag, and GitHub Markdown generally does not parse **...** emphasis inside HTML elements, so this is likely to render the literal ** characters instead of bold text. To get reliable bold (and match existing conventions like actions/setup/js/validate_secrets.cjs:600), wrap the summary text in <strong> (or <b>) rather than using Markdown emphasis, and update the related test assertions accordingly.
| section += `> <summary>**🔒 Integrity filter blocked ${count} ${itemWord}**</summary>\n`; | |
| section += `> <summary><strong>🔒 Integrity filter blocked ${count} ${itemWord}</strong></summary>\n`; |
| let section = "\n\n> [!WARNING]\n"; | ||
| section += `> <details>\n`; | ||
| section += `> <summary>⚠️ Firewall blocked ${domainCount} ${domainWord}</summary>\n`; | ||
| section += `> <summary>**⚠️ Firewall blocked ${domainCount} ${domainWord}**</summary>\n`; |
There was a problem hiding this comment.
<summary> is emitted as HTML, and Markdown emphasis (**...**) typically isn’t parsed inside HTML tags in GitHub-flavored Markdown. This can cause the UI to show the literal ** instead of bold text. For consistent rendering (and to align with existing usage like actions/setup/js/validate_secrets.cjs:600), use <summary><strong>…</strong></summary> (or <b>) and update the tests to match.
| section += `> <summary>**⚠️ Firewall blocked ${domainCount} ${domainWord}**</summary>\n`; | |
| section += `> <summary><strong>⚠️ Firewall blocked ${domainCount} ${domainWord}</strong></summary>\n`; |
Three minor copy and style changes to the integrity filter blocked message, remediation text, and firewall blocked section.
Changes
gateway_difc_filtered.cjs: Updated blocked item message from"don't meet the GitHub \min-integrity` level"→"don't meet the GitHub integrity level"(drops themin-prefix and the inline doc link); madefirewall_blocked_domains.cjs: Made<summary>text bold to match the same conventionintegrity_filter_remediation.md: Removed trailing"See Integrity Filtering for more information."sentencegateway_difc_filtered.test.cjsandfirewall_blocked_domains.test.cjs: Updated assertions to match the new message text and bold summary format⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.