Skip to content

fix: update integrity filter blocked message and bold summary headers#22173

Merged
pelikhan merged 3 commits intomainfrom
copilot/update-integrity-filter-message
Mar 21, 2026
Merged

fix: update integrity filter blocked message and bold summary headers#22173
pelikhan merged 3 commits intomainfrom
copilot/update-integrity-filter-message

Conversation

Copy link
Contributor

Copilot AI commented Mar 21, 2026

Three minor copy and style changes to the integrity filter blocked message, remediation text, and firewall blocked section.

Changes

  • gateway_difc_filtered.cjs: Updated blocked item message from "don't meet the GitHub \min-integrity` level""don't meet the GitHub integrity level"(drops themin-prefix and the inline doc link); made` text bold
  • firewall_blocked_domains.cjs: Made <summary> text bold to match the same convention
  • integrity_filter_remediation.md: Removed trailing "See Integrity Filtering for more information." sentence
  • gateway_difc_filtered.test.cjs and firewall_blocked_domains.test.cjs: Updated assertions to match the new message text and bold summary format

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

Copilot AI changed the title [WIP] Update integrity filter message for clarity fix: remove "min-" prefix from integrity filter blocked message Mar 21, 2026
Copilot AI requested a review from pelikhan March 21, 2026 18:15
@pelikhan
Copy link
Contributor

@copilot always make details summary bold

…blocked sections

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/430547cc-7977-463f-b7ff-a7e718b43a1d
Copy link
Contributor Author

Copilot AI commented Mar 21, 2026

@copilot always make details summary bold

Done in d7df56a. Made the summary text bold (**...**) in both gateway_difc_filtered.cjs (🔒 Integrity filter blocked) and firewall_blocked_domains.cjs (⚠️ Firewall blocked), and updated all corresponding test assertions.

Copilot AI changed the title fix: remove "min-" prefix from integrity filter blocked message fix: update integrity filter blocked message and bold summary headers Mar 21, 2026
@pelikhan pelikhan marked this pull request as ready for review March 21, 2026 18:36
Copilot AI review requested due to automatic review settings March 21, 2026 18:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates copy/styling for integrity-filter and firewall “blocked” step-summary sections, plus aligns associated tests and remediation text.

Changes:

  • Adjusts integrity-filter blocked message text and removes the trailing “See Integrity Filtering…” sentence from remediation markdown.
  • Makes <summary> headers bold for integrity-filter and firewall blocked sections.
  • Updates unit tests to assert the new message text and summary formatting.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
actions/setup/md/integrity_filter_remediation.md Removes trailing documentation sentence from remediation snippet.
actions/setup/js/gateway_difc_filtered.cjs Updates integrity blocked message text; attempts to bold the <summary> label.
actions/setup/js/gateway_difc_filtered.test.cjs Updates assertions for new integrity message and summary formatting.
actions/setup/js/firewall_blocked_domains.cjs Attempts to bold the <summary> label in the firewall blocked section.
actions/setup/js/firewall_blocked_domains.test.cjs Updates assertions for the new firewall summary formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

let section = "\n\n> [!NOTE]\n";
section += `> <details>\n`;
section += `> <summary>🔒 Integrity filter blocked ${count} ${itemWord}</summary>\n`;
section += `> <summary>**🔒 Integrity filter blocked ${count} ${itemWord}**</summary>\n`;
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<summary> is an HTML tag, and GitHub Markdown generally does not parse **...** emphasis inside HTML elements, so this is likely to render the literal ** characters instead of bold text. To get reliable bold (and match existing conventions like actions/setup/js/validate_secrets.cjs:600), wrap the summary text in <strong> (or <b>) rather than using Markdown emphasis, and update the related test assertions accordingly.

Suggested change
section += `> <summary>**🔒 Integrity filter blocked ${count} ${itemWord}**</summary>\n`;
section += `> <summary><strong>🔒 Integrity filter blocked ${count} ${itemWord}</strong></summary>\n`;

Copilot uses AI. Check for mistakes.
let section = "\n\n> [!WARNING]\n";
section += `> <details>\n`;
section += `> <summary>⚠️ Firewall blocked ${domainCount} ${domainWord}</summary>\n`;
section += `> <summary>**⚠️ Firewall blocked ${domainCount} ${domainWord}**</summary>\n`;
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<summary> is emitted as HTML, and Markdown emphasis (**...**) typically isn’t parsed inside HTML tags in GitHub-flavored Markdown. This can cause the UI to show the literal ** instead of bold text. For consistent rendering (and to align with existing usage like actions/setup/js/validate_secrets.cjs:600), use <summary><strong>…</strong></summary> (or <b>) and update the tests to match.

Suggested change
section += `> <summary>**⚠️ Firewall blocked ${domainCount} ${domainWord}**</summary>\n`;
section += `> <summary><strong>⚠️ Firewall blocked ${domainCount} ${domainWord}</strong></summary>\n`;

Copilot uses AI. Check for mistakes.
@pelikhan pelikhan merged commit 9c53e8a into main Mar 21, 2026
97 of 141 checks passed
@pelikhan pelikhan deleted the copilot/update-integrity-filter-message branch March 21, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants