fix: remove required inputs from smoke-* workflows, always provide defaults by Copilot · Pull Request #22361 · github/gh-aw

Copilot · 2026-03-23T02:48:23Z

Summary

Removes required: true from all inputs in smoke-* workflows so they can be triggered manually (via workflow_dispatch) without having to provide input values. Defaults are always provided.

Changes

Compiler fixes (affect all `label_command` workflows)

pkg/workflow/tools.go: The auto-generated workflow_dispatch.inputs.item_number for label_command workflows now has required: false and default: ""
pkg/workflow/label_trigger_parser.go: Same fix for the shorthand label-trigger expansion path

Smoke workflow source fixes

smoke-copilot.md and smoke-copilot-arm.md: send-slack-message.message input changed to required: false with default: ""
smoke-claude.md: post-slack-message.channel and .message inputs changed to required: false with defaults (#general and "")

Test/golden file updates

pkg/workflow/label_trigger_parser_test.go: Updated assertions to expect required: false with empty default
pkg/workflow/testdata/wasm_golden/fixtures/smoke-copilot.md: Synced with smoke-copilot.md changes
All 177 lock files recompiled

…faults Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3e923da6-a161-47ac-ae10-b80ee3a98e9c

Copilot

Pull request overview

This PR makes smoke/label-command workflows manually triggerable without requiring users to fill workflow inputs, by setting inputs to required: false and providing defaults, and then syncing tests/golden/lock outputs.

Changes:

Update compiler paths to generate workflow_dispatch.inputs.item_number with required: false and default: "" for label-command workflows.
Update smoke workflow sources to make Slack-related inputs optional with defaults.
Update test expectations and regenerate golden/lock artifacts.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/workflow/tools.go	Compiler: generated `workflow_dispatch.inputs.item_number` is now optional with empty-string default.
pkg/workflow/label_trigger_parser.go	Parser shorthand expansion: same `item_number` optional + default behavior.
pkg/workflow/label_trigger_parser_test.go	Test assertions updated for `required: false` and `default: ""`.
pkg/workflow/testdata/wasm_golden/fixtures/smoke-copilot.md	Golden fixture updated to reflect optional Slack message input with empty default.
.github/workflows/smoke-copilot.md	Smoke workflow source: `send-slack-message.message` now optional with default `""`.
.github/workflows/smoke-copilot.lock.yml	Recompiled lock output reflecting the workflow/input changes.
.github/workflows/smoke-copilot-arm.md	ARM smoke workflow source: `send-slack-message.message` now optional with default `""`.
.github/workflows/smoke-copilot-arm.lock.yml	Recompiled lock output reflecting the workflow/input changes.
.github/workflows/smoke-claude.md	Smoke workflow source: `post-slack-message.channel/message` now optional with defaults.
.github/workflows/smoke-claude.lock.yml	Recompiled lock output reflecting the workflow/input changes.
.github/workflows/refiner.lock.yml	Recompiled lock output: `workflow_dispatch.inputs.item_number` now optional with empty default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T02:54:58Z

.github/workflows/smoke-copilot.lock.yml

          mkdir -p /tmp/gh-aw/mcp-logs/safeoutputs
          cat > ${RUNNER_TEMP}/gh-aw/safeoutputs/config.json << 'GH_AW_SAFE_OUTPUTS_CONFIG_EOF'
-          {"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"reply_to_pull_request_review_comment":{"max":5},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"default":null,"description":"The message to send","required":true,"type":"string"}},"output":"Slack message stub executed!"},"set_issue_type":{"max":5},"submit_pull_request_review":{"max":1}}
+          {"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"reply_to_pull_request_review_comment":{"max":5},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"description":"The message to send","required":false,"type":"string"}},"output":"Slack message stub executed!"},"set_issue_type":{"max":5},"submit_pull_request_review":{"max":1}}


The generated safe-outputs config.json payload for send-slack-message.message no longer includes a default value even though the source workflow declares default: "". If the agent omits message, downstream steps that read .message can end up seeing null/missing instead of an empty string. Consider preserving explicit empty-string defaults in the generated config.json (and then regenerating lock files) so runtime normalization consistently applies the intended default.

Suggested change

{"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"reply_to_pull_request_review_comment":{"max":5},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"description":"The message to send","required":false,"type":"string"}},"output":"Slack message stub executed!"},"set_issue_type":{"max":5},"submit_pull_request_review":{"max":1}}

{"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"reply_to_pull_request_review_comment":{"max":5},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"default":"","description":"The message to send","required":false,"type":"string"}},"output":"Slack message stub executed!"},"set_issue_type":{"max":5},"submit_pull_request_review":{"max":1}}

Copilot · 2026-03-23T02:54:59Z

.github/workflows/smoke-copilot-arm.lock.yml

          mkdir -p /tmp/gh-aw/mcp-logs/safeoutputs
          cat > ${RUNNER_TEMP}/gh-aw/safeoutputs/config.json << 'GH_AW_SAFE_OUTPUTS_CONFIG_EOF'
-          {"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot-arm"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"default":null,"description":"The message to send","required":true,"type":"string"}},"output":"Slack message stub executed!"},"submit_pull_request_review":{"max":1}}
+          {"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot-arm"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"description":"The message to send","required":false,"type":"string"}},"output":"Slack message stub executed!"},"submit_pull_request_review":{"max":1}}


Same as smoke-copilot.lock.yml: the safe-outputs config.json entry for send-slack-message.message is missing the explicit default: "" even though the workflow source declares it. This can lead to null/missing values when the agent omits the input, rather than the intended empty-string default.

Suggested change

{"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot-arm"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"description":"The message to send","required":false,"type":"string"}},"output":"Slack message stub executed!"},"submit_pull_request_review":{"max":1}}

{"add_comment":{"allowed_repos":["github/gh-aw"],"max":2},"add_labels":{"allowed":["smoke-copilot-arm"],"allowed_repos":["github/gh-aw"],"max":3},"create_discussion":{"expires":2,"max":1},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"dispatch_workflow":{"max":1,"workflow_files":{"haiku-printer":".yml"},"workflows":["haiku-printer"]},"missing_data":{},"missing_tool":{},"noop":{"max":1},"remove_labels":{"allowed":["smoke"],"max":3},"send-slack-message":{"description":"Send a message to Slack (stub for testing)","inputs":{"message":{"description":"The message to send","required":false,"type":"string","default":""}},"output":"Slack message stub executed!"},"submit_pull_request_review":{"max":1}}

Copilot · 2026-03-23T02:54:59Z

.github/workflows/smoke-claude.lock.yml

          mkdir -p /tmp/gh-aw/mcp-logs/safeoutputs
          cat > ${RUNNER_TEMP}/gh-aw/safeoutputs/config.json << 'GH_AW_SAFE_OUTPUTS_CONFIG_EOF'
-          {"add_comment":{"max":2},"add_labels":{"allowed":["smoke-claude"],"max":3},"add_reviewer":{"max":2},"close_pull_request":{"max":1,"staged":true},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"missing_data":{},"missing_tool":{},"noop":{"max":1},"post_slack_message":{"description":"Post a message to a fictitious Slack channel (smoke test only — no real Slack integration)","inputs":{"channel":{"default":null,"description":"Slack channel name to post to","required":true,"type":"string"},"message":{"default":null,"description":"Message text to post","required":true,"type":"string"}}},"push_to_pull_request_branch":{"max":1,"target":"*"},"resolve_pull_request_review_thread":{"max":5},"submit_pull_request_review":{"max":1},"update_pull_request":{"max":1}}
+          {"add_comment":{"max":2},"add_labels":{"allowed":["smoke-claude"],"max":3},"add_reviewer":{"max":2},"close_pull_request":{"max":1,"staged":true},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"missing_data":{},"missing_tool":{},"noop":{"max":1},"post_slack_message":{"description":"Post a message to a fictitious Slack channel (smoke test only — no real Slack integration)","inputs":{"channel":{"default":"#general","description":"Slack channel name to post to","required":false,"type":"string"},"message":{"description":"Message text to post","required":false,"type":"string"}}},"push_to_pull_request_branch":{"max":1,"target":"*"},"resolve_pull_request_review_thread":{"max":5},"submit_pull_request_review":{"max":1},"update_pull_request":{"max":1}}


In the generated safe-outputs config.json, post_slack_message.inputs.message is now optional but has no default field, while the workflow source declares default: "" (and channel retains its default). For consistency (and to avoid null/missing message values at runtime), consider ensuring empty-string defaults are preserved in config.json generation and then regenerate this lock file.

Suggested change

{"add_comment":{"max":2},"add_labels":{"allowed":["smoke-claude"],"max":3},"add_reviewer":{"max":2},"close_pull_request":{"max":1,"staged":true},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"missing_data":{},"missing_tool":{},"noop":{"max":1},"post_slack_message":{"description":"Post a message to a fictitious Slack channel (smoke test only — no real Slack integration)","inputs":{"channel":{"default":"#general","description":"Slack channel name to post to","required":false,"type":"string"},"message":{"description":"Message text to post","required":false,"type":"string"}}},"push_to_pull_request_branch":{"max":1,"target":"*"},"resolve_pull_request_review_thread":{"max":5},"submit_pull_request_review":{"max":1},"update_pull_request":{"max":1}}

{"add_comment":{"max":2},"add_labels":{"allowed":["smoke-claude"],"max":3},"add_reviewer":{"max":2},"close_pull_request":{"max":1,"staged":true},"create_issue":{"expires":2,"group":true,"max":1},"create_pull_request_review_comment":{"max":5},"missing_data":{},"missing_tool":{},"noop":{"max":1},"post_slack_message":{"description":"Post a message to a fictitious Slack channel (smoke test only — no real Slack integration)","inputs":{"channel":{"default":"#general","description":"Slack channel name to post to","required":false,"type":"string"},"message":{"default":"","description":"Message text to post","required":false,"type":"string"}}},"push_to_pull_request_branch":{"max":1,"target":"*"},"resolve_pull_request_review_thread":{"max":5},"submit_pull_request_review":{"max":1},"update_pull_request":{"max":1}}

fix: remove required inputs from smoke-* workflows, always provide de…

2970ebe

…faults Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3e923da6-a161-47ac-ae10-b80ee3a98e9c

Copilot AI assigned Copilot and pelikhan Mar 23, 2026

Copilot created this pull request from a session on behalf of pelikhan March 23, 2026 02:49 View session

Copilot AI requested a review from pelikhan March 23, 2026 02:49

Copilot finished work on behalf of pelikhan March 23, 2026 02:49

pelikhan approved these changes Mar 23, 2026

View reviewed changes

pelikhan marked this pull request as ready for review March 23, 2026 02:50

Copilot AI review requested due to automatic review settings March 23, 2026 02:50

pelikhan merged commit 7f9a53f into main Mar 23, 2026

pelikhan deleted the copilot/remove-required-inputs-smoke-tests branch March 23, 2026 02:50

Copilot started reviewing on behalf of pelikhan March 23, 2026 02:51 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

This was referenced Mar 23, 2026

Add blocked-users and approval-labels to tools.github guard policy #22360

Merged

Smoke Test: Claude - 23420748984 #22369

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove required inputs from smoke-* workflows, always provide defaults#22361

fix: remove required inputs from smoke-* workflows, always provide defaults#22361
pelikhan merged 1 commit intomainfrom
copilot/remove-required-inputs-smoke-tests

Copilot AI commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 23, 2026

Summary

Changes

Compiler fixes (affect all label_command workflows)

Smoke workflow source fixes

Test/golden file updates

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Compiler fixes (affect all `label_command` workflows)