[jsweep] Clean add_labels.cjs by github-actions[bot] · Pull Request #22366 · github/gh-aw

github-actions · 2026-03-23T03:26:44Z

Summary

Analyzed and improved add_labels.cjs (github-script context handler for adding labels to issues/PRs).

Analysis

The add_labels.cjs file is already clean and modern — @ts-check enabled, optional chaining, proper JSDoc types, no unnecessary try/catch. The HANDLER_TYPE constant, while seemingly unused in logic, is intentionally required by the safe_outputs_type_validation.test.cjs type-marker test and must be retained.

The main opportunity was test coverage gaps for three untested code paths.

Changes

add_labels.test.cjs — Added 4 new tests (25 → 29 tests):

New Test	What it covers
`should preview labels in staged mode without calling API`	Staged mode returns `{ success: true, staged: true, previewInfo }` without making GitHub API call
`should count staged calls toward processedCount`	Staged mode still increments `processedCount`, enforcing the max limit
`should filter out labels matching blocked patterns`	`blocked: ["internal-", "~"]` correctly removes matching labels while keeping valid ones
`should succeed with empty labelsAdded when all labels filtered by allowed list`	When all requested labels are not in the allowed list, returns `{ success: true, labelsAdded: [], message: "No valid labels found" }`

Context

Execution context: github-script (uses core, github, context globals)
Key dependencies: validateLabels, isStagedMode, resolveAndValidateRepo, tryEnforceArrayLimit

Validation ✅

All checks passed:

Formatting: npm run format:cjs ✓
Linting: npm run lint:cjs ✓
Type checking: npm run typecheck ✓
Tests: npx vitest run add_labels.test.cjs safe_outputs_type_validation.test.cjs — 42 tests passed ✓

Warning

**⚠️ Firewall blocked 2 domains**

The following domains were blocked by the firewall during workflow execution:

invalid.example.invalid
proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "invalid.example.invalid"
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by jsweep - JavaScript Unbloater · ◷

expires on Mar 25, 2026, 3:26 AM UTC

…ltered labels - Add test for staged mode preview without calling API - Add test that staged calls count toward processedCount limit - Add test for blocked pattern filtering (removes matching labels) - Add test for when all labels are filtered out by allowed list (succeeds with empty labelsAdded) Total: 25 → 29 tests for add_labels handler Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Improves confidence in the add_labels.cjs handler by adding tests for previously untested execution paths (staged mode behavior and label filtering scenarios).

Changes:

Added tests verifying staged mode returns preview info and does not call the GitHub API.
Added tests ensuring staged mode still counts toward the max processed limit.
Added tests covering blocked-pattern filtering and the “no valid labels” success path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T03:43:13Z

actions/setup/js/add_labels.test.cjs

+      );
+
+      expect(result.success).toBe(true);
+      expect(result.labelsAdded).toEqual(["bug", "enhancement"]);


This test assumes the GitHub API is called exactly once, but it never asserts the call count. Adding an explicit assertion (e.g., that addLabelsCalls has length 1) would prevent the test from passing if the handler accidentally performs multiple addLabels calls.

Suggested change

expect(result.labelsAdded).toEqual(["bug", "enhancement"]);

expect(result.labelsAdded).toEqual(["bug", "enhancement"]);

expect(addLabelsCalls).toHaveLength(1);

Copilot · 2026-03-23T03:43:13Z

actions/setup/js/add_labels.test.cjs

+      expect(result.success).toBe(true);
+      expect(result.labelsAdded).toEqual([]);
+      expect(result.message).toContain("No valid labels");
+    });


This test doesn’t verify that the handler avoids calling github.rest.issues.addLabels when no valid labels remain after filtering. Consider stubbing addLabels (as in other tests) and asserting it was not called, so the behavior remains protected against regressions.

pelikhan · 2026-03-23T03:45:37Z

@copilot fix https://github.com/github/gh-aw/actions/runs/23420415449/job/68124164769

…h inputs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3ead85d8-c115-425f-88b4-18f27175e720

Copilot · 2026-03-23T03:53:43Z

@copilot fix https://github.com/github/gh-aw/actions/runs/23420415449/job/68124164769

Fixed in fd58d1d. The TestLabelTriggerIntegrationSimple failure was a mismatch in label_trigger_parser.go where item_number was set to required: false but the test expected required: true. Changed it to required: true (also removed the now-unnecessary default: "") and recompiled the affected lock file (refiner.lock.yml).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw 2dnbhUlAbVwI (http block)
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw ire (http block)
https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
- Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha h ../../../.pret.prettierignore (http block)
https://api.github.com/repos/github/gh-aw
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .visibility (http block)
https://api.github.com/repos/githubnext/agentics/git/ref/tags/
- Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2026-03-23T03:59:29Z

@copilot fix https://github.com/github/gh-aw/actions/runs/23420694869/job/68125125011

…se for item_number input Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/531637cf-d8c8-415b-8b02-277e0e917422

Copilot · 2026-03-23T04:06:16Z

@copilot fix https://github.com/github/gh-aw/actions/runs/23420694869/job/68125125011

Fixed in 62acaad. The issue was that TestLabelTriggerIntegrationSimple had an incorrect assertion expecting required: true, while both the production code and TestExpandLabelTriggerShorthand unit tests use required: false. Fixed the integration test to match the actual behavior. label_trigger_parser.go and refiner.lock.yml are back to their original state.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw /tmp/go-build3850348696/b001/importcfg -pack /tmp/go-build3850348696/b001/_testmain.go (http block)
https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
- Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
https://api.github.com/repos/github/gh-aw
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .visibility (http block)
https://api.github.com/repos/githubnext/agentics/git/ref/tags/
- Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

github-actions bot added automation unbloat labels Mar 23, 2026

pelikhan marked this pull request as ready for review March 23, 2026 03:40

Copilot AI review requested due to automatic review settings March 23, 2026 03:40

Copilot started reviewing on behalf of pelikhan March 23, 2026 03:41 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Copilot started work on behalf of pelikhan March 23, 2026 03:45 View session

fix: set item_number required=true for label trigger workflow_dispatc…

fd58d1d

…h inputs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3ead85d8-c115-425f-88b4-18f27175e720

Copilot AI requested a review from pelikhan March 23, 2026 03:54

Copilot finished work on behalf of pelikhan March 23, 2026 03:54

Copilot started work on behalf of pelikhan March 23, 2026 03:59 View session

github-actions bot mentioned this pull request Mar 23, 2026

Smoke Test: Claude - 23420748984 #22369

Closed

fix: correct TestLabelTriggerIntegrationSimple to expect required=fal…

62acaad

…se for item_number input Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw/sessions/531637cf-d8c8-415b-8b02-277e0e917422

Copilot finished work on behalf of pelikhan March 23, 2026 04:06

pelikhan merged commit 2d7781d into main Mar 23, 2026
53 checks passed

pelikhan deleted the jsweep/add-labels-cleanup-869ba564f0c6992b branch March 23, 2026 04:23

github-actions bot mentioned this pull request Mar 23, 2026

Add blocked-users and approval-labels to tools.github guard policy #22360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[jsweep] Clean add_labels.cjs#22366

[jsweep] Clean add_labels.cjs#22366
pelikhan merged 3 commits intomainfrom
jsweep/add-labels-cleanup-869ba564f0c6992b

github-actions bot commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

pelikhan commented Mar 23, 2026

Uh oh!

Copilot AI commented Mar 23, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan commented Mar 23, 2026

Uh oh!

Copilot AI commented Mar 23, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	expect(result.labelsAdded).toEqual(["bug", "enhancement"]);
	expect(result.labelsAdded).toEqual(["bug", "enhancement"]);
	expect(addLabelsCalls).toHaveLength(1);

Conversation

github-actions bot commented Mar 23, 2026

Summary

Analysis

Changes

Context

Validation ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Mar 23, 2026

Uh oh!

Copilot AI commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan commented Mar 23, 2026

Uh oh!

Copilot AI commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 23, 2026 •

edited

Loading

Copilot AI commented Mar 23, 2026 •

edited

Loading