Skip to content

Make build-wasm a dependency of agent-finish #22422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 23, 2026
+11 −11
Merged

Make build-wasm a dependency of agent-finish #22422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54737db
Add build-wasm as dependency of agent-finish
Copilot Mar 23, 2026
9c2c306
Add build-wasm as dependency of agent-finish
Copilot Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/aw/actions-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@
"version": "v4.34.1",
"sha": "cb06a0a8527b2c6970741b3a0baa15231dc74a4c"
},
"github/gh-aw-actions/setup@v0": {
"repo": "github/gh-aw-actions/setup",
"version": "v0",
"sha": "50f4fc16883c6c6672d8879affa8fd15d5cc79a4"
},
"github/gh-aw-actions/setup@v0.62.5": {
"repo": "github/gh-aw-actions/setup",
"version": "v0.62.5",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/smoke-claude.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ sbom:

# Agent should run this task before finishing its turns
.PHONY: agent-finish
agent-finish: deps-dev fmt lint build test-all fix recompile dependabot generate-schema-docs generate-agent-factory security-scan
agent-finish: deps-dev fmt lint build build-wasm test-all fix recompile dependabot generate-schema-docs generate-agent-factory security-scan
Copy link
Contributor

@github-actions github-actions bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change: adding build-wasm as a dependency of agent-finish ensures WASM compilation is validated as part of the standard finish sequence. This prevents the silent gap where golden files could drift out of sync.

Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding build-wasm to agent-finish causes make agent-finish to create gh-aw.wasm in the repo root (build-wasm target outputs -o gh-aw.wasm). Unlike the main gh-aw binary, gh-aw.wasm is not currently ignored in .gitignore, so automation that runs agent-finish (e.g., formatting/commit flows) may end up with an unexpected untracked file or accidentally commit it. Consider either writing the wasm artifact to an ignored output directory (e.g., dist/ or tmp/) or adding /gh-aw.wasm to .gitignore.

Suggested change
agent-finish: deps-dev fmt lint build build-wasm test-all fix recompile dependabot generate-schema-docs generate-agent-factory security-scan
agent-finish: deps-dev fmt lint build test-all fix recompile dependabot generate-schema-docs generate-agent-factory security-scan

Copilot uses AI. Check for mistakes.
@echo "Agent finished tasks successfully."

# Help target
Expand Down
11 changes: 3 additions & 8 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,6 @@
"version": "v4.34.1",
"sha": "cb06a0a8527b2c6970741b3a0baa15231dc74a4c"
},
"github/gh-aw-actions/setup@v0": {
"repo": "github/gh-aw-actions/setup",
"version": "v0",
"sha": "50f4fc16883c6c6672d8879affa8fd15d5cc79a4"
},
"github/gh-aw-actions/setup@v0.62.5": {
"repo": "github/gh-aw-actions/setup",
"version": "v0.62.5",
Expand All @@ -168,10 +163,10 @@
"version": "v2.10.3",
"sha": "9cd1b7bf3f36d5a3c3b17abc3545bfb5481912ea"
},
"microsoft/apm-action@v1.3.4": {
"microsoft/apm-action@v1.4.0": {
Copy link
Contributor

@github-actions github-actions bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The microsoft/apm-action SHA update from v1.3.4 → v1.4.0 looks correct. The pin is properly updated to the new commit SHA for security pinning.

"repo": "microsoft/apm-action",
"version": "v1.3.4",
"sha": "83d54a6c7941049210433b16c8dfac573665b12a"
"version": "v1.4.0",
"sha": "cc84c04bc73e19e35527f1efa34ea003be9f037f"
},
"oven-sh/setup-bun@v2.2.0": {
"repo": "oven-sh/setup-bun",
Expand Down
Loading