Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/daily-cli-performance.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/issue-monster.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions pkg/workflow/compiler_orchestrator_workflow.go
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,24 @@ func (c *Compiler) processOnSectionAndFilters(
if err != nil {
return err
}

// Apply action pinning to on.steps
if len(onSteps) > 0 {
anySteps := make([]any, len(onSteps))
for i, s := range onSteps {
anySteps[i] = s
Comment on lines +869 to +873
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New behavior (SHA-pinning for on.steps) isn’t covered by an automated test. There are tests for on.steps injection (e.g., pkg/workflow/on_steps_test.go), but none assert that uses: entries inside on.steps are rewritten to pinned SHAs in the generated lock YAML. Please add/extend a test to compile a workflow containing on.steps with a uses: actions/...@v* step and assert the lock output contains the pinned SHA form (including the # v* comment).

Copilot uses AI. Check for mistakes.
}
typedSteps, convErr := SliceToSteps(anySteps)
if convErr == nil {
typedSteps = ApplyActionPinsToTypedSteps(typedSteps, workflowData)
for i, s := range typedSteps {
onSteps[i] = s.ToMap()
}
} else {
orchestratorWorkflowLog.Printf("Failed to convert on.steps to typed steps for action pinning: %v", convErr)
}
}

workflowData.OnSteps = onSteps

// Extract on.permissions for pre-activation job permissions
Expand Down
Loading