[dead-code] chore: remove dead functions — 2 functions removed

[github-actions]

Dead Code Removal

This PR removes unreachable Go functions identified by the deadcode static analyzer.

Functions Removed

Function	File
ExtractWorkflowNameFromMarkdown	pkg/parser/frontmatter_content.go
ExtractMarkdown	pkg/parser/frontmatter_content.go

Both functions are superseded by in-memory equivalents (ExtractWorkflowNameFromMarkdownBody, ExtractMarkdownContent) that avoid redundant file I/O and are used throughout the production codebase.

Tests Removed

Test Function	File
TestExtractWorkflowNameFromMarkdown	pkg/parser/frontmatter_utils_test.go
TestExtractMarkdown	pkg/parser/frontmatter_utils_test.go

Also removed a stale comment in pkg/parser/frontmatter_includes_test.go that referenced the deleted function.

Verification

• ✅ go build ./... — passes
• ✅ go vet ./... — passes
• ✅ go vet -tags=integration ./... — passes
• ✅ make fmt — no changes needed
• ✅ go test ./pkg/parser/... — passes

Dead Function Count

• Before this batch: ~19 functions reported by deadcode
• Removed in this PR: 2 functions
• Remaining: ~17 functions (several skipped: WASM-live functions, test infrastructure, cached from prior runs)

---

Automated by Dead Code Removal workflow — https://github.com/github/gh-aw/actions/runs/23461486296

Generated by Dead Code Removal Agent · ◷

• expires on Mar 26, 2026, 9:49 PM UTC

[Copilot]

Pull request overview

Removes unreachable parser helpers and associated tests identified by deadcode, consolidating usage on the existing in-memory parsing functions.

Changes:

• Deleted file-based helpers ExtractWorkflowNameFromMarkdown and ExtractMarkdown from pkg/parser/frontmatter_content.go.
• Removed unit tests that exercised the deleted functions from pkg/parser/frontmatter_utils_test.go.
• Removed a stale test comment referencing the deleted API in pkg/parser/frontmatter_includes_test.go.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
pkg/parser/frontmatter_content.go	Removes file-I/O-based helpers (and their os dependency), leaving in-memory equivalents.
pkg/parser/frontmatter_utils_test.go	Deletes tests that targeted the removed APIs.
pkg/parser/frontmatter_includes_test.go	Removes a stale comment referencing the removed function.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The doc comment mentions ExtractWorkflowNameFromMarkdown, but that function is removed in this PR. Please update the comment to avoid referencing the deleted symbol (e.g., only compare to ExtractWorkflowNameFromContent).

Suggested change

	// efficient than ExtractWorkflowNameFromMarkdown or ExtractWorkflowNameFromContent because it
	// efficient than ExtractWorkflowNameFromContent and any file-based variants because it

[Copilot]

Removing these tests also removes coverage of the workflow-name extraction behavior (H1 detection + filename fallback), which is still exercised by ExtractWorkflowNameFromContent / ExtractWorkflowNameFromMarkdownBody in production. Consider reintroducing equivalent tests targeting the in-memory APIs so this behavior remains covered.

See below for a potential fix:

func TestExtractWorkflowNameFromContent_H1Title(t *testing.T) {
	content := []byte("# My Workflow Title\n\nSome other content.")
	filename := "fallback-name.md"

	got := ExtractWorkflowNameFromContent(content, filename)
	want := "My Workflow Title"

	if got != want {
		t.Errorf("ExtractWorkflowNameFromContent() with H1 title = %q, want %q", got, want)
	}
}

func TestExtractWorkflowNameFromContent_FilenameFallback(t *testing.T) {
	content := []byte("No heading here, just body content.")
	filename := "owner/repo/.github/workflows/sample-workflow.md"

	got := ExtractWorkflowNameFromContent(content, filename)
	want := "sample-workflow"

	if got != want {
		t.Errorf("ExtractWorkflowNameFromContent() filename fallback = %q, want %q", got, want)
	}
}

func TestExtractWorkflowNameFromMarkdownBody_H1Title(t *testing.T) {
	body := "# Another Workflow\n\nDetails about this workflow."
	filename := "another-fallback.md"

	got := ExtractWorkflowNameFromMarkdownBody(body, filename)
	want := "Another Workflow"

	if got != want {
		t.Errorf("ExtractWorkflowNameFromMarkdownBody() with H1 title = %q, want %q", got, want)
	}
}

func TestExtractWorkflowNameFromMarkdownBody_FilenameFallback(t *testing.T) {
	body := "Content without any level-1 heading."
	filename := "owner/repo/.github/workflows/body-fallback.md"

	got := ExtractWorkflowNameFromMarkdownBody(body, filename)
	want := "body-fallback"

	if got != want {
		t.Errorf("ExtractWorkflowNameFromMarkdownBody() filename fallback = %q, want %q", got, want)
	}
}