Skip to content

ci-doctor: remove workflow_run, stop-after, and if#22615

Merged
pelikhan merged 2 commits intomainfrom
copilot/update-ci-doctor-workflow
Mar 24, 2026
Merged

ci-doctor: remove workflow_run, stop-after, and if#22615
pelikhan merged 2 commits intomainfrom
copilot/update-ci-doctor-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

Removes three frontmatter fields from the ci-doctor workflow:

  • workflow_run trigger (and its sub-configuration)
  • stop-after: +1mo
  • Top-level if: condition

Recompiled the lock file accordingly.

Copilot AI requested a review from pelikhan March 24, 2026 06:01
@pelikhan pelikhan marked this pull request as ready for review March 24, 2026 06:02
Copilot AI review requested due to automatic review settings March 24, 2026 06:02
@pelikhan pelikhan merged commit 59b196d into main Mar 24, 2026
47 of 49 checks passed
@pelikhan pelikhan deleted the copilot/update-ci-doctor-workflow branch March 24, 2026 06:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused/undesired frontmatter controls from the ci-doctor agentic workflow so it no longer triggers on workflow_run, no longer has a stop-time cutoff, and no longer relies on a top-level conditional.

Changes:

  • Removed the workflow_run trigger from .github/workflows/ci-doctor.md.
  • Removed stop-after: +1mo and the top-level if: condition from the workflow source and recompiled the generated lock workflow accordingly.
  • Updated the compiled workflow (ci-doctor.lock.yml) to activate only on PR label events for ci-doctor and to drop the stop-time enforcement step.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci-doctor.md Removes workflow_run, stop-after, and top-level if from the workflow frontmatter.
.github/workflows/ci-doctor.lock.yml Recompiled output reflecting trigger/activation changes and removal of stop-time gating.
Comments suppressed due to low confidence (1)

.github/workflows/ci-doctor.md:6

  • With the workflow_run trigger removed from the frontmatter, the workflow's workflow_run-specific mode/steps in this file become unreachable (e.g., steps guarded by if: github.event_name == 'workflow_run' and the "CI Failure Investigation Mode" section later). Consider removing that mode/steps or updating the trigger/docs so the behavior is consistent and future readers aren’t misled.
on:
  label_command:
    name: ci-doctor
    events: [pull_request]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,21 +1,9 @@
---
description: Investigates failed CI workflows to identify root causes and patterns, creating issues with diagnostic information; also reviews PR check failures when the ci-doctor label is applied
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the workflow_run trigger, the workflow no longer automatically investigates failed CI runs. The frontmatter description still says it investigates failed CI workflows and creates issues; please update it to reflect the remaining PR label-triggered behavior (or reintroduce an appropriate trigger).

This issue also appears on line 3 of the same file.

Suggested change
description: Investigates failed CI workflows to identify root causes and patterns, creating issues with diagnostic information; also reviews PR check failures when the ci-doctor label is applied
description: Reviews PR CI and check failures when the ci-doctor label command is used, identifying root causes and patterns and creating issues with diagnostic information as needed

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants