[ca] fix: update wasm golden files for aw_context description change#22624
Merged
[ca] fix: update wasm golden files for aw_context description change#22624
Conversation
Update golden test files to reflect the updated description of the aw_context workflow_dispatch input from: '(Internal) JSON context injected by the calling agentic workflow. Not intended for direct user input.' to: 'Agent caller context (used internally by Agentic Workflows).' Fixes CI failure in TestWasmGolden_CompileFixtures tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WASM golden fixtures so TestWasmGolden_CompileFixtures matches the current aw_context workflow_dispatch input description.
Changes:
- Replaces the old
aw_contextinput description text with the new, shorter wording. - Updates three affected golden fixture outputs used by
TestWasmGolden_CompileFixtures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates aw_context.description text in the compiled golden output. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden | Updates aw_context.description text in the compiled golden output. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden | Updates aw_context.description text in the compiled golden output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI was failing on
TestWasmGolden_CompileFixturestests due to outdated golden files.Root Cause
The description of the
aw_contextworkflow dispatch input was updated inpkg/workflow/compiler_aw_context.gofrom:to:
However, the golden test fixture files were not updated to reflect this change.
Fixes Applied
aw_contextdescription:pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.goldenpkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.goldenpkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.goldenValidation
make fmt- Code formatted successfully (no changes needed)make test-unit- All unit tests pass (fixedTestWasmGolden_CompileFixtures)make recompile- All 177 workflows compiled successfully (no lock file changes)Triggered by failed CI run: https://github.com/github/gh-aw/actions/runs/23475784864