Skip to content

Fix filterJobLevelPermissions dropping explicit empty permissions block #22720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Mar 24, 2026
Merged

Fix filterJobLevelPermissions dropping explicit empty permissions block #22720

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
501ae9e
Initial plan
Copilot Mar 24, 2026
f615a07
Merge branch 'main' into copilot/fix-github-actions-workflow-99e9f472…
pelikhan Mar 24, 2026
718dc5f
Fix filterJobLevelPermissions to preserve explicit empty permissions: {}
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/workflow/permissions_operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ func filterJobLevelPermissions(rawPermissionsYAML string) string {
filtered := NewPermissionsParser(rawPermissionsYAML).ToPermissions()
rendered := filtered.RenderToYAML()
if rendered == "" {
// If the raw permissions YAML was an explicit empty block (permissions: {}), preserve
// it at the job level. Without this check, "permissions: {}" would be silently dropped,
// leaving the job without any permissions block and causing it to inherit the workflow-
// level permissions instead of having its own explicit empty block.
if strings.TrimSpace(rawPermissionsYAML) == "permissions: {}" {
return "permissions: {}"
}
return ""
}

Expand Down
Loading