Skip to content

docs(engines): clarify model field comment as override example#22819

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-model-field-example-mismatch
Mar 25, 2026
Merged

docs(engines): clarify model field comment as override example#22819
pelikhan merged 2 commits intomainfrom
copilot/fix-model-field-example-mismatch

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

The model field in the "Extended Coding Agent Configuration" example had a value/comment mismatch — model: gpt-5 paired with # defaults to claude-sonnet-4 simultaneously demonstrated an override and claimed to document the default, making the intent ambiguous.

Change

Updated the comment to make the intent explicit:

# Before
model: gpt-5                          # defaults to claude-sonnet-4

# After
model: gpt-5                          # example override; omit to use engine default

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix model field example/comment mismatch in docs docs(engines): clarify model field comment as override example Mar 25, 2026
Copilot AI requested a review from pelikhan March 25, 2026 02:13
@pelikhan pelikhan marked this pull request as ready for review March 25, 2026 02:17
Copilot AI review requested due to automatic review settings March 25, 2026 02:18
@pelikhan pelikhan merged commit ee152fd into main Mar 25, 2026
@pelikhan pelikhan deleted the copilot/fix-model-field-example-mismatch branch March 25, 2026 02:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies the intent of the model field comment in the “Extended Coding Agent Configuration” example so it’s unambiguously an override example rather than a statement about the default model.

Changes:

  • Updated the inline YAML comment for engine.model to indicate it’s an example override and that omitting it uses the engine default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(engines): model field example/comment mismatch

3 participants