Extract extraction functions from compiler.go to frontmatter_extraction.go

[Copilot]

Overview

Refactored frontmatter extraction logic by consolidating 13 extraction/parsing functions into a dedicated frontmatter_extraction.go file. This improves code organization and makes extraction logic easier to find, test, and maintain.

Changes

File Reorganization

• Renamed: pkg/workflow/parse_utils.go → pkg/workflow/frontmatter_extraction.go
• Reduced: pkg/workflow/compiler.go by 435 lines
• Reduced: pkg/workflow/network.go by 35 lines

Functions Moved to frontmatter_extraction.go

From compiler.go (12 functions):

• extractTopLevelYAMLSection - Extracts top-level YAML sections with field ordering
• extractPermissions - Extracts permissions using the permission parser
• extractIfCondition - Extracts if conditions without prefix
• extractFeatures - Extracts feature flags map
• extractDescription - Extracts description field
• extractSource - Extracts source field
• extractSafetyPromptSetting - Extracts safety-prompt setting from tools
• extractToolsTimeout - Extracts timeout setting from tools
• extractToolsStartupTimeout - Extracts startup-timeout setting from tools
• extractExpressionFromIfString - Extracts expression from if string
• extractCommandConfig - Extracts command configuration including name and events
• extractYAMLValue - Extracts scalar values from frontmatter (already existed in parse_utils.go)

From network.go (1 function):

• extractNetworkPermissions - Extracts network permissions (was misplaced in runtime file)

Helper functions also moved:

• commentOutProcessedFieldsInOnSection - Used by extractTopLevelYAMLSection
• buildSourceURL - Used by extractSource and safe output files

Benefits

1. Better Organization: All frontmatter extraction logic is now centralized in one file
2. Improved Maintainability: Easier to locate and modify extraction functions
3. Cleaner Separation: compiler.go focuses on compilation logic, not extraction
4. Correct Placement: extractNetworkPermissions moved from network.go (runtime) to extraction utilities

Testing

• ✅ All unit tests pass
• ✅ Build successful
• ✅ No breaking changes to existing functionality

Closes #2274 (part of #2273)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[task] Extract extraction functions from compiler.go to frontmatter_extraction.go</issue_title>
<issue_description>## Objective
Extract 12 extraction/parsing functions from pkg/workflow/compiler.go and consolidate with existing extraction utilities into a renamed and enhanced pkg/workflow/frontmatter_extraction.go.

Context

Part of issue #2273. The compiler.go file contains extraction functions that should be in a dedicated extraction utilities file. This will improve code organization and make extraction logic easier to find and test.

Functions to Extract from compiler.go

Move these 12 extraction functions:

• extractTopLevelYAMLSection
• extractPermissions
• extractIfCondition
• extractFeatures
• extractDescription
• extractSource
• extractSafetyPromptSetting
• extractToolsTimeout
• extractToolsStartupTimeout
• extractExpressionFromIfString
• extractCommandConfig
• extractYAMLValue

Additional Extraction Functions to Move

From pkg/workflow/network.go:

• extractNetworkPermissions (currently misplaced in runtime file)

Approach

1. Rename pkg/workflow/parse_utils.go to pkg/workflow/frontmatter_extraction.go
2. Move all extraction functions from compiler.go to this file
3. Move extractNetworkPermissions from network.go to this file
4. Organize functions logically within the file
5. Update all imports and references

Files to Modify

• Rename: pkg/workflow/parse_utils.go → pkg/workflow/frontmatter_extraction.go
• Update: pkg/workflow/compiler.go (remove extraction functions)
• Update: pkg/workflow/network.go (remove extractNetworkPermissions)

Acceptance Criteria

• frontmatter_extraction.go created (renamed from parse_utils.go)
• All 12 extraction functions moved from compiler.go
• extractNetworkPermissions moved from network.go
• All tests pass: make test-unit
• Code compiles successfully: make build
• No import errors or broken references
• compiler.go reduced by approximately 200-300 lines
  Related to [refactor] 🔧 Semantic Function Clustering Analysis - Refactoring Opportunities #2273

AI generated by Plan Command for #2273</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #2276

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[github-actions]

Agentic Changeset Generator triggered by this pull request.