Skip to content

Add download.jetbrains.com to kotlin ecosystem domain allowlist #22942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 3 commits into from
Mar 25, 2026
Merged

Add download.jetbrains.com to kotlin ecosystem domain allowlist #22942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4df3085
Initial plan
Copilot Mar 25, 2026
1b0519b
Add download.jetbrains.com to kotlin ecosystem domain allowlist
Copilot Mar 25, 2026
9c3158a
Merge branch 'main' into copilot/add-missing-domains-kotlin-ecosystem
Mossaka Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workflow/data/ecosystem_domains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
"*.gradle-enterprise.cloud"
],
"julia": ["pkg.julialang.org", "*.pkg.julialang.org", "julialang.org", "julialang-s3.julialang.org", "storage.julialang.net"],
"kotlin": ["ge.jetbrains.com", "packages.jetbrains.team", "kotlin.bintray.com", "maven.pkg.jetbrains.space"],
"kotlin": ["download.jetbrains.com", "ge.jetbrains.com", "packages.jetbrains.team", "kotlin.bintray.com", "maven.pkg.jetbrains.space"],
"linux-distros": [
"deb.debian.org",
"security.debian.org",
Expand Down
26 changes: 24 additions & 2 deletions pkg/workflow/ecosystem_domains_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,28 @@ func TestEcosystemDomainExpansion(t *testing.T) {
}
})

t.Run("kotlin ecosystem includes JetBrains and Kotlin domains", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"kotlin"},
}
domains := GetAllowedDomains(permissions)

expectedDomains := []string{
"download.jetbrains.com",
"ge.jetbrains.com",
"packages.jetbrains.team",
"kotlin.bintray.com",
"maven.pkg.jetbrains.space",
}

for _, expectedDomain := range expectedDomains {
found := slices.Contains(domains, expectedDomain)
if !found {
t.Errorf("Expected domain '%s' to be included in kotlin ecosystem, but it was not found", expectedDomain)
}
}
})

t.Run("multiple ecosystems can be combined", func(t *testing.T) {
permissions := &NetworkPermissions{
Allowed: []string{"defaults", "dotnet", "python", "example.com"},
Expand Down Expand Up @@ -389,7 +411,7 @@ func TestAllEcosystemDomainFunctions(t *testing.T) {
// Test that all ecosystem categories return non-empty slices
ecosystemCategories := []string{
"defaults", "containers", "bazel", "dotnet", "dart", "github", "go",
"terraform", "haskell", "java", "julia", "linux-distros", "lua", "node",
"terraform", "haskell", "java", "julia", "kotlin", "linux-distros", "lua", "node",
"ocaml", "perl", "php", "playwright", "python", "r", "ruby", "rust", "swift",
}

Expand All @@ -414,7 +436,7 @@ func TestEcosystemDomainsUniqueness(t *testing.T) {
// Test that each ecosystem category returns unique domains (no duplicates)
ecosystemCategories := []string{
"defaults", "containers", "bazel", "dotnet", "dart", "github", "go",
"terraform", "haskell", "java", "julia", "linux-distros", "lua", "node",
"terraform", "haskell", "java", "julia", "kotlin", "linux-distros", "lua", "node",
"ocaml", "perl", "php", "playwright", "python", "r", "ruby", "rust", "swift",
}

Expand Down
Loading