[docs] Consolidate developer specifications into instructions file#23090
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
[docs] Consolidate developer specifications into instructions file#23090github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Integrate newly added scratchpad/metrics-glossary.md into the consolidated developer instructions file. Adds a Related Documentation link describing the standardized metric names and scopes used across daily report workflows. No tone issues found in the new spec file. Coverage: 63 spec files (100%). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
automation
documentation
This was referenced Mar 26, 2026
Closed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
| **Version**: 4.3 | ||
| **Last Updated**: 2026-03-25 | ||
| **Version**: 4.4 | ||
| **Last Updated**: 2026-03-26 |
Contributor
Author
There was a problem hiding this comment.
✅ Version bump and date look correct for this consolidation pass.
| - [Testing Guidelines](./testing.md) - Testing framework: assert vs require, fuzz tests, security regression tests, benchmarks, and `make` test commands | ||
| - [Token Budget Guidelines](./token-budget-guidelines.md) - Token budget targets and optimization strategies: `max-turns` engine restrictions (Claude/Custom only), `timeout-minutes` configuration, and prompt optimization patterns for Copilot workflows | ||
| - [Custom GitHub Actions Build System](./actions.md) - Custom Go-based actions build system: directory structure (`actions/`), build tooling (`pkg/cli/actions_build_command.go`), action modes (standard vs dev), and CI integration | ||
| - [Daily Reports Metrics Glossary](./metrics-glossary.md) - Standardized metric names and scopes for cross-report comparisons: issue, PR, workflow, firewall, code quality, observability, and Copilot agent metrics; scope documentation conventions; validation rules for regulatory reports |
Contributor
Author
There was a problem hiding this comment.
📝 New metrics-glossary.md entry in Related Documentation — description is clear and well-scoped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer Documentation Consolidation
This PR integrates
scratchpad/metrics-glossary.md— a newly added spec file — into the consolidated developer instructions filescratchpad/dev.md.Changes Made
metrics-glossary.md(standardized metric names for daily report cross-comparisons)scratchpad/dev.mdupdated: v4.3 → v4.4metrics-glossary.mdValidation
✅ 0 tone issues found
✅ 0 formatting issues
✅ 10 Mermaid diagrams retained
✅ 63/63 spec files covered (100%)
✅ Consistent technical tone throughout
Review Notes
Please verify:
metrics-glossary.mdlink and description in Related Documentation is accurateSee the consolidation discussion for the full analysis report.
✨ PR Review Safe Output Test - Run 23594519542